third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForBindings.h - Issue 2285183005: Use StringView in Dictionary and DictionaryHelper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForBindings.h

Issue 2285183005: Use StringView in Dictionary and DictionaryHelper. (Closed)

Patch Set: rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForBindings.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForBindings.h b/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForBindings.h

index 10be3d8072f5579bc10d197750a5afb86ac69349..4f565a77e30adc2f482872595423c8ee80001e6c 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForBindings.h

+++ b/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForBindings.h

@@ -32,7 +32,7 @@

namespace blink {

template <template <typename> class PointerType, typename T>

-bool DictionaryHelper::get(const Dictionary& dictionary, const String& key, PointerType<T>& value)

+bool DictionaryHelper::get(const Dictionary& dictionary, const StringView& key, PointerType<T>& value)

{

v8::Local<v8::Value> v8Value;

if (!dictionary.get(key, v8Value))