[layoutng] Move and rename NGBoxMargins to NGBoxStrut

[layoutng] Move and rename NGBoxMargins to NGBoxStrut

I want to reuse this struct for borders and padding as well, so I want
to rename it to a more generic name, and it belongs more to ng_units.h

R=eae@chromium.org,ikilpatrick@chromium.org
BUG=635619
Committed: https://crrev.com/595223a9a96bf85570f9e7b846e4e1a789ef164d
Cr-Commit-Position: refs/heads/master@{#414658}

[cbiesinger, 2016-08-25 23:09:55]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 23:10:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2016-08-25 23:36:28]

lgtm, we may need to switch this to physical space for storage, but can build
that bridge when we come to it.

[cbiesinger1, 2016-08-25 23:41:13]

The CQ bit was unchecked by cbiesinger@google.com

[cbiesinger1, 2016-08-25 23:41:25]

The CQ bit was checked by cbiesinger@google.com

[commit-bot: I haz the power, 2016-08-25 23:41:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-08-25 23:51:29]

Yeah. For now I mostly envision this to be used in the local layout
function and not stored but we'll see

On Aug 25, 2016 19:36, <ikilpatrick@chromium.org> wrote:

> lgtm, we may need to switch this to physical space for storage, but can
> build
> that bridge when we come to it.
>
> https://codereview.chromium.org/2281763002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[cbiesinger, 2016-08-25 23:51:29]

Yeah. For now I mostly envision this to be used in the local layout
function and not stored but we'll see

On Aug 25, 2016 19:36, <ikilpatrick@chromium.org> wrote:

> lgtm, we may need to switch this to physical space for storage, but can
> build
> that bridge when we come to it.
>
> https://codereview.chromium.org/2281763002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[eae, 2016-08-25 23:51:57]

LGTM

[commit-bot: I haz the power, 2016-08-26 01:07:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 01:07:40]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[cbiesinger1, 2016-08-26 01:08:12]

The CQ bit was checked by cbiesinger@google.com

[commit-bot: I haz the power, 2016-08-26 01:08:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 03:48:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 03:48:32]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[cbiesinger1, 2016-08-26 03:48:58]

The CQ bit was checked by cbiesinger@google.com

[commit-bot: I haz the power, 2016-08-26 03:49:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 06:29:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-26 06:31:05]

Description was changed from

==========
[layoutng] Move and rename NGBoxMargins to NGBoxStrut

I want to reuse this struct for borders and padding as well, so I want
to rename it to a more generic name, and it belongs more to ng_units.h

R=eae@chromium.org,ikilpatrick@chromium.org
BUG=635619
==========

to

==========
[layoutng] Move and rename NGBoxMargins to NGBoxStrut

I want to reuse this struct for borders and padding as well, so I want
to rename it to a more generic name, and it belongs more to ng_units.h

R=eae@chromium.org,ikilpatrick@chromium.org
BUG=635619

Committed: https://crrev.com/595223a9a96bf85570f9e7b846e4e1a789ef164d
Cr-Commit-Position: refs/heads/master@{#414658}
==========

[commit-bot: I haz the power, 2016-08-26 06:31:06]

Patchset 1 (id:??) landed as
https://crrev.com/595223a9a96bf85570f9e7b846e4e1a789ef164d
Cr-Commit-Position: refs/heads/master@{#414658}