Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc

Issue 2281763002: [layoutng] Move and rename NGBoxMargins to NGBoxStrut (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc
index ec098cc2c769230931e68215b9b0544ee01a3adf..234c2d01f1bc14a82d85b0468535b8934b1ae44d 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc
@@ -5,7 +5,6 @@
#include "core/layout/ng/ng_length_utils.h"
#include "core/layout/ng/ng_constraint_space.h"
-#include "core/layout/ng/ng_margin_strut.h"
#include "core/style/ComputedStyle.h"
#include "platform/LayoutUnit.h"
#include "platform/Length.h"
@@ -116,11 +115,11 @@ LayoutUnit computeBlockSizeForFragment(const NGConstraintSpace& constraintSpace,
return extent;
}
-NGBoxMargins computeMargins(const NGConstraintSpace& constraintSpace,
- const ComputedStyle& style) {
+NGBoxStrut computeMargins(const NGConstraintSpace& constraintSpace,
+ const ComputedStyle& style) {
// Margins always get computed relative to the inline size:
// https://www.w3.org/TR/CSS2/box.html#value-def-margin-width
- NGBoxMargins margins;
+ NGBoxStrut margins;
margins.inline_start = resolveInlineLength(
constraintSpace, style.marginStart(), LengthResolveType::MarginSize);
margins.inline_end = resolveInlineLength(constraintSpace, style.marginEnd(),

Powered by Google App Engine
This is Rietveld 408576698