third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc - Issue 2281763002: [layoutng] Move and rename NGBoxMargins to NGBoxStrut

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

Issue 2281763002: [layoutng] Move and rename NGBoxMargins to NGBoxStrut (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

index 73e221b6d9702528b2c79711f05540920566f150..edaa5a02441b24cc80384b7962f838c2fb8fdf31 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc

@@ -5,7 +5,6 @@

#include "core/layout/ng/ng_length_utils.h"

#include "core/layout/ng/ng_constraint_space.h"

-#include "core/layout/ng/ng_margin_strut.h"

#include "core/style/ComputedStyle.h"

#include "platform/CalculationValue.h"

#include "platform/LayoutUnit.h"

@@ -182,7 +181,7 @@ TEST_F(NGLengthUtilsTest, testMargins) {

NGConstraintSpace constraintSpace(constructConstraintSpace(200, 300));

- NGBoxMargins margins = computeMargins(constraintSpace, *style_);

+ NGBoxStrut margins = computeMargins(constraintSpace, *style_);

EXPECT_EQ(LayoutUnit(20), margins.block_start);

EXPECT_EQ(LayoutUnit(52), margins.inline_end);