Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2281583003: services/ui: Split GpuServiceInternal into gpu vs. ws pieces. (Closed)

Created:
4 years, 3 months ago by sadrul
Modified:
4 years, 3 months ago
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@DONE_2016.08.24_mus-ws-gpu-refactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services/ui: Split GpuServiceInternal into gpu vs. ws pieces. Notable changes: . MusGpuMemoryBufferManager is meant to be used by the gpu host (i.e. GpuServiceProxy). So move it into ws. It still has a temporary dependency on GpuServiceInternal. It will converted to communicate with it over mojom API instead. . Convert GpuServiceProxy (which is the gpu-host, running in the window server) into GpuChannelHostFactory, and responsible for managing the gpu-channel for the host. . Introduce a |privileged| parameter in GpuServiceInternal API. This privileged channel is created only for the host (and by the host). . Move ownership of GpuServiceProxy into WindowServer. It makes it easier for GpuServiceProxy to notify when the gpu-channel has been established through a Delegate interface. . DisplayCompositor instance is now created in the window server after the gpu-channel has been established. The gpu channel is passed through PlatformDisplay and FrameGenerator from WindowServer. BUG=613366 Committed: https://crrev.com/212f35700eeb17abc2c5e2e1a54e08c70c13ed23 Cr-Commit-Position: refs/heads/master@{#414901}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : tot merge #

Total comments: 15

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Patch Set 14 : tot merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -326 lines) Patch
M services/ui/gpu/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/gpu/DEPS View 1 2 3 4 5 1 chunk +0 lines, -14 lines 0 comments Download
M services/ui/gpu/gpu_service_internal.h View 1 2 3 4 5 6 7 8 9 10 7 chunks +17 lines, -36 lines 0 comments Download
M services/ui/gpu/gpu_service_internal.cc View 1 2 3 4 5 6 7 8 9 10 7 chunks +6 lines, -45 lines 0 comments Download
M services/ui/gpu/interfaces/gpu_service_internal.mojom View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -1 line 0 comments Download
M services/ui/gpu/mus_gpu_memory_buffer_manager.h View 1 2 3 4 5 1 chunk +0 lines, -57 lines 0 comments Download
M services/ui/gpu/mus_gpu_memory_buffer_manager.cc View 1 2 3 4 5 1 chunk +0 lines, -116 lines 0 comments Download
M services/ui/public/cpp/gpu_service.cc View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M services/ui/service.h View 1 2 3 4 5 6 7 8 9 2 chunks +0 lines, -2 lines 0 comments Download
M services/ui/service.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +1 line, -3 lines 0 comments Download
M services/ui/ws/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +8 lines, -3 lines 0 comments Download
M services/ui/ws/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +7 lines, -3 lines 0 comments Download
M services/ui/ws/frame_generator.h View 3 chunks +8 lines, -0 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +18 lines, -7 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +32 lines, -5 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +60 lines, -3 lines 0 comments Download
A services/ui/ws/gpu_service_proxy_delegate.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +28 lines, -0 lines 0 comments Download
A + services/ui/ws/mus_gpu_memory_buffer_manager.h View 1 2 3 4 5 4 chunks +6 lines, -5 lines 0 comments Download
A + services/ui/ws/mus_gpu_memory_buffer_manager.cc View 1 2 3 4 5 5 chunks +10 lines, -20 lines 0 comments Download
M services/ui/ws/platform_display.h View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +11 lines, -0 lines 0 comments Download
M services/ui/ws/platform_display.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +6 lines, -0 lines 0 comments Download
M services/ui/ws/test_utils.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -0 lines 0 comments Download
M services/ui/ws/window_server.h View 1 2 3 4 5 6 7 8 9 10 6 chunks +10 lines, -0 lines 0 comments Download
M services/ui/ws/window_server.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 49 (40 generated)
sadrul
tsepez@ for mojom changes. sky@ for ws changes, specifically, moving the ownership of GpuServiceProxy from ...
4 years, 3 months ago (2016-08-26 15:36:35 UTC) #21
Fady Samuel
lgtm + optional bikeshed colors. https://codereview.chromium.org/2281583003/diff/180001/services/ui/gpu/gpu_service_internal.cc File services/ui/gpu/gpu_service_internal.cc (right): https://codereview.chromium.org/2281583003/diff/180001/services/ui/gpu/gpu_service_internal.cc#newcode244 services/ui/gpu/gpu_service_internal.cc:244: bool privileged, Maybe be ...
4 years, 3 months ago (2016-08-26 16:27:59 UTC) #26
sky
I think it's a bit weird to have the ws namespace in a couple of ...
4 years, 3 months ago (2016-08-26 16:46:30 UTC) #27
sadrul
https://codereview.chromium.org/2281583003/diff/180001/services/ui/gpu/gpu_service_internal.cc File services/ui/gpu/gpu_service_internal.cc (right): https://codereview.chromium.org/2281583003/diff/180001/services/ui/gpu/gpu_service_internal.cc#newcode244 services/ui/gpu/gpu_service_internal.cc:244: bool privileged, On 2016/08/26 16:27:59, Fady Samuel wrote: > ...
4 years, 3 months ago (2016-08-26 17:23:50 UTC) #32
Tom Sepez
lgtm
4 years, 3 months ago (2016-08-26 18:51:37 UTC) #35
no sievers
gpu deps lgtm
4 years, 3 months ago (2016-08-26 20:10:02 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281583003/260001
4 years, 3 months ago (2016-08-27 00:22:25 UTC) #45
commit-bot: I haz the power
Committed patchset #14 (id:260001)
4 years, 3 months ago (2016-08-27 10:48:10 UTC) #47
commit-bot: I haz the power
4 years, 3 months ago (2016-08-27 10:49:58 UTC) #49
Message was sent while issue was closed.
Patchset 14 (id:??) landed as
https://crrev.com/212f35700eeb17abc2c5e2e1a54e08c70c13ed23
Cr-Commit-Position: refs/heads/master@{#414901}

Powered by Google App Engine
This is Rietveld 408576698