Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2278573002: [api] Disable copy constructors in the public section. (Closed)

Created:
4 years, 4 months ago by Franzi
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Disable copy constructors in the public section. According to our style guide on Copyable and Movable Types, copy/move operators should be disabled in the public: section, not in the private: section. BUG= Committed: https://crrev.com/ceadddd15d3dbd7be5e300909a3fdc848297e6b2 Cr-Commit-Position: refs/heads/master@{#38872}

Patch Set 1 #

Messages

Total messages: 13 (7 generated)
Franzi
PTAL
4 years, 4 months ago (2016-08-24 16:17:59 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-24 16:19:16 UTC) #5
jochen (gone - plz use gerrit)
if you search for operator= in that header, you'll find a bunch of classes that ...
4 years, 4 months ago (2016-08-24 16:20:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2278573002/1
4 years, 4 months ago (2016-08-24 16:25:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 16:27:50 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 16:28:17 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ceadddd15d3dbd7be5e300909a3fdc848297e6b2
Cr-Commit-Position: refs/heads/master@{#38872}

Powered by Google App Engine
This is Rietveld 408576698