Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: include/v8.h

Issue 2278573002: [api] Disable copy constructors in the public section. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index c93ee238585f5a86527532eb6e927ac7906a9ccb..6a8747459dd7013b7ac60110bf29f1953988fb28 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -615,6 +615,9 @@ template <class T> class PersistentBase {
*/
V8_INLINE uint16_t WrapperClassId() const;
+ PersistentBase(const PersistentBase& other) = delete; // NOLINT
+ void operator=(const PersistentBase&) = delete;
+
private:
friend class Isolate;
friend class Utils;
@@ -630,8 +633,6 @@ template <class T> class PersistentBase {
friend class Object;
explicit V8_INLINE PersistentBase(T* val) : val_(val) {}
- PersistentBase(const PersistentBase& other) = delete; // NOLINT
- void operator=(const PersistentBase&) = delete;
V8_INLINE static T* New(Isolate* isolate, T* that);
T* val_;
@@ -835,11 +836,12 @@ class Global : public PersistentBase<T> {
*/
typedef void MoveOnlyTypeForCPP03;
+ Global(const Global&) = delete;
+ void operator=(const Global&) = delete;
+
private:
template <class F>
friend class ReturnValue;
- Global(const Global&) = delete;
- void operator=(const Global&) = delete;
V8_INLINE T* operator*() const { return this->val_; }
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698