Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2271043003: Disable copy constructor in public: section or use macro. (Closed)

Created:
4 years, 3 months ago by Franzi
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable copy constructor in public: section or use macro. According to our style guide on Copyable and Movable Types, copy/move operators should be disabled in the public: section, not in the private: section. If disabled with a macro such as DISALLOW_COPY_AND_ASSIGN, it should be at the end of the private: section, and should be the last thing in the class. BUG= Committed: https://crrev.com/b2fee84f8739632f9df9224c40c6ad52443c4066 Cr-Commit-Position: refs/heads/master@{#38878}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M src/background-parsing-task.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/frames.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/handles.h View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
Franzi
PTAL
4 years, 3 months ago (2016-08-24 16:51:37 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-24 20:48:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2271043003/1
4 years, 3 months ago (2016-08-25 03:11:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 03:13:17 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 03:13:48 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2fee84f8739632f9df9224c40c6ad52443c4066
Cr-Commit-Position: refs/heads/master@{#38878}

Powered by Google App Engine
This is Rietveld 408576698