Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 2284303003: Minor cleanup. Use namespace i instead of v8::internal. (Closed)

Created:
4 years, 3 months ago by Franzi
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Minor cleanup. Use namespace i instead of v8::internal. BUG= Committed: https://crrev.com/93358294af8bed5b9dcae671a659b868c6cb7389 Cr-Commit-Position: refs/heads/master@{#38972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M src/api.cc View 5 chunks +10 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
Franzi
PTAL. Thanks, Franzi
4 years, 3 months ago (2016-08-29 08:07:43 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-29 09:26:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284303003/1
4 years, 3 months ago (2016-08-29 09:32:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 09:34:37 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 09:34:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93358294af8bed5b9dcae671a659b868c6cb7389
Cr-Commit-Position: refs/heads/master@{#38972}

Powered by Google App Engine
This is Rietveld 408576698