Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 2272063002: [api] Disable copy constructors using = delete. (Closed)

Created:
4 years, 3 months ago by Franzi
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Disable copy constructors using = delete. According to our style guide on Copyable and Movable Types, copy/move operators should be disabled using = delete in the public: section, not in the private: section. BUG= Committed: https://crrev.com/6effe72f4629558f07540382e9368ac5db6e051c Cr-Commit-Position: refs/heads/master@{#38879}

Patch Set 1 #

Patch Set 2 : Fix depends on problem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -67 lines) Patch
M include/v8.h View 21 chunks +77 lines, -67 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
Franzi
Here are the changes to use = delete in public: for v8.h.
4 years, 3 months ago (2016-08-24 17:42:53 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-24 20:47:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2272063002/40001
4 years, 3 months ago (2016-08-25 03:29:44 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-08-25 04:23:52 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 04:24:14 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6effe72f4629558f07540382e9368ac5db6e051c
Cr-Commit-Position: refs/heads/master@{#38879}

Powered by Google App Engine
This is Rietveld 408576698