services/ui: Rename a few gpu-related classes.

services/ui: Rename a few gpu-related classes.

. Rename GpuServiceMus to GpuServiceInternal.
. Rename GpuServiceImpl to GpuServiceProxy, and move it into the
  window-server directory.
. Instead of creating a new instance of GpuServiceProxy for each
  client, update GpuServiceProxy so that a single instance can service
  all clients

BUG=613366
Committed: https://crrev.com/c3a1438df0ff289a410fa52e47d0910c9f7d42ec
Cr-Commit-Position: refs/heads/master@{#414200}

[sadrul, 2016-08-24 15:33:41]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 15:34:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-24 15:36:54]

sadrul@chromium.org changed reviewers:
+ fsamuel@chromium.org, rjkroege@chromium.org

[sadrul, 2016-08-24 15:36:55]

An [almost] no-op rename + relocation.

[Fady Samuel, 2016-08-24 15:44:12]

This is a big improvement overall. I'm not sure if I like the naming yet but
it's better than before. I will refrain from bikeshedding. I do have a question
but I won't block this CL on it. LGTM

https://codereview.chromium.org/2276433004/diff/20001/services/ui/ws/gpu_serv...
File services/ui/ws/gpu_service_proxy.h (right):

https://codereview.chromium.org/2276433004/diff/20001/services/ui/ws/gpu_serv...
services/ui/ws/gpu_service_proxy.h:19: class GpuServiceProxy : public
mojom::GpuService {
Hmm, do we know that the gpu service interface will be identical to this "proxy"
or should we have two interfaces?

[sadrul, 2016-08-24 15:47:53]

I don't feel strongly about the names, but I think the current names in this CL
do sort of make sense to me. Happy to rename if you have suggestions though.

https://codereview.chromium.org/2276433004/diff/20001/services/ui/ws/gpu_serv...
File services/ui/ws/gpu_service_proxy.h (right):

https://codereview.chromium.org/2276433004/diff/20001/services/ui/ws/gpu_serv...
services/ui/ws/gpu_service_proxy.h:19: class GpuServiceProxy : public
mojom::GpuService {
On 2016/08/24 15:44:11, Fady Samuel wrote:
> Hmm, do we know that the gpu service interface will be identical to this
"proxy"
> or should we have two interfaces?

This is the client-facing interface. The one between ws and gpu
(GpuServiceInternal) will have a slightly different API (e.g. it will include
the Initialize()/Crash() etc. things too, and the signatures will also be a bit
different).

[Fady Samuel, 2016-08-24 15:54:46]

On 2016/08/24 15:47:53, sadrul wrote:
> I don't feel strongly about the names, but I think the current names in this
CL
> do sort of make sense to me. Happy to rename if you have suggestions though.
> 
>
https://codereview.chromium.org/2276433004/diff/20001/services/ui/ws/gpu_serv...
> File services/ui/ws/gpu_service_proxy.h (right):
> 
>
https://codereview.chromium.org/2276433004/diff/20001/services/ui/ws/gpu_serv...
> services/ui/ws/gpu_service_proxy.h:19: class GpuServiceProxy : public
> mojom::GpuService {
> On 2016/08/24 15:44:11, Fady Samuel wrote:
> > Hmm, do we know that the gpu service interface will be identical to this
> "proxy"
> > or should we have two interfaces?
> 
> This is the client-facing interface. The one between ws and gpu
> (GpuServiceInternal) will have a slightly different API (e.g. it will include
> the Initialize()/Crash() etc. things too, and the signatures will also be a
bit
> different).

I think we should delay bikeshedding names until we get a better picture of the
roles of the various objects. :-) LGTM++

[sadrul, 2016-08-24 16:58:37]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2016-08-24 16:58:38]

+sky@ for owner

[commit-bot: I haz the power, 2016-08-24 17:23:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 17:23:16]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sadrul, 2016-08-24 17:25:25]

Description was changed from

==========
services/ui: Rename a few gpu-related classes.

. Rename GpuServiceMus to GpuServiceInternal.
. Rename GpuServiceImpl to GpuServiceProxy, and move it into the
  window-server directory.
. Instead of creating a new instance of GpuServiceProxy for each
  client, update GpuServiceProxy so that a single instance can service
  all clients

BUG=none
==========

to

==========
services/ui: Rename a few gpu-related classes.

. Rename GpuServiceMus to GpuServiceInternal.
. Rename GpuServiceImpl to GpuServiceProxy, and move it into the
  window-server directory.
. Instead of creating a new instance of GpuServiceProxy for each
  client, update GpuServiceProxy so that a single instance can service
  all clients

BUG=613366
==========

[sky, 2016-08-24 19:39:27]

LGTM

[sadrul, 2016-08-24 19:53:05]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-08-24 19:54:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 23:41:22]

Description was changed from

==========
services/ui: Rename a few gpu-related classes.

. Rename GpuServiceMus to GpuServiceInternal.
. Rename GpuServiceImpl to GpuServiceProxy, and move it into the
  window-server directory.
. Instead of creating a new instance of GpuServiceProxy for each
  client, update GpuServiceProxy so that a single instance can service
  all clients

BUG=613366
==========

to

==========
services/ui: Rename a few gpu-related classes.

. Rename GpuServiceMus to GpuServiceInternal.
. Rename GpuServiceImpl to GpuServiceProxy, and move it into the
  window-server directory.
. Instead of creating a new instance of GpuServiceProxy for each
  client, update GpuServiceProxy so that a single instance can service
  all clients

BUG=613366
==========

[commit-bot: I haz the power, 2016-08-24 23:41:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-24 23:44:33]

Description was changed from

==========
services/ui: Rename a few gpu-related classes.

. Rename GpuServiceMus to GpuServiceInternal.
. Rename GpuServiceImpl to GpuServiceProxy, and move it into the
  window-server directory.
. Instead of creating a new instance of GpuServiceProxy for each
  client, update GpuServiceProxy so that a single instance can service
  all clients

BUG=613366
==========

to

==========
services/ui: Rename a few gpu-related classes.

. Rename GpuServiceMus to GpuServiceInternal.
. Rename GpuServiceImpl to GpuServiceProxy, and move it into the
  window-server directory.
. Instead of creating a new instance of GpuServiceProxy for each
  client, update GpuServiceProxy so that a single instance can service
  all clients

BUG=613366

Committed: https://crrev.com/c3a1438df0ff289a410fa52e47d0910c9f7d42ec
Cr-Commit-Position: refs/heads/master@{#414200}
==========

[commit-bot: I haz the power, 2016-08-24 23:44:34]

Patchset 2 (id:??) landed as
https://crrev.com/c3a1438df0ff289a410fa52e47d0910c9f7d42ec
Cr-Commit-Position: refs/heads/master@{#414200}