Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: services/ui/ws/gpu_service_proxy.h

Issue 2276433004: services/ui: Rename a few gpu-related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/ws/BUILD.gn ('k') | services/ui/ws/gpu_service_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/ws/gpu_service_proxy.h
diff --git a/services/ui/gpu/gpu_service_impl.h b/services/ui/ws/gpu_service_proxy.h
similarity index 60%
rename from services/ui/gpu/gpu_service_impl.h
rename to services/ui/ws/gpu_service_proxy.h
index 677923e8562b077c1c83849f266159f370b731dd..1650c523d92f363664864f0a76a6ffc2d88e42c2 100644
--- a/services/ui/gpu/gpu_service_impl.h
+++ b/services/ui/ws/gpu_service_proxy.h
@@ -2,21 +2,28 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef SERVICES_UI_GPU_GPU_SERVICE_IMPL_H_
-#define SERVICES_UI_GPU_GPU_SERVICE_IMPL_H_
+#ifndef SERVICES_UI_WS_GPU_SERVICE_PROXY_H_
+#define SERVICES_UI_WS_GPU_SERVICE_PROXY_H_
+#include "mojo/public/cpp/bindings/binding_set.h"
#include "mojo/public/cpp/bindings/interface_request.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
#include "services/ui/public/interfaces/gpu_memory_buffer.mojom.h"
#include "services/ui/public/interfaces/gpu_service.mojom.h"
namespace ui {
-class GpuServiceImpl : public mojom::GpuService {
+class GpuServiceInternal;
+
+// The proxy implementation that relays requests from clients to the real
+// service implementation in the GPU process over mojom.GpuServiceInternal.
+class GpuServiceProxy : public mojom::GpuService {
Fady Samuel 2016/08/24 15:44:11 Hmm, do we know that the gpu service interface wil
sadrul 2016/08/24 15:47:53 This is the client-facing interface. The one betwe
public:
- GpuServiceImpl(mojo::InterfaceRequest<mojom::GpuService> request);
- ~GpuServiceImpl() override;
+ GpuServiceProxy();
+ ~GpuServiceProxy() override;
+
+ void Add(mojom::GpuServiceRequest request);
+ private:
// mojom::GpuService overrides:
void EstablishGpuChannel(
const mojom::GpuService::EstablishGpuChannelCallback& callback) override;
@@ -33,12 +40,12 @@ class GpuServiceImpl : public mojom::GpuService {
void DestroyGpuMemoryBuffer(mojom::GpuMemoryBufferIdPtr id,
const gpu::SyncToken& sync_token) override;
- private:
- mojo::StrongBinding<GpuService> binding_;
+ GpuServiceInternal* gpu_service_;
+ mojo::BindingSet<GpuService> bindings_;
- DISALLOW_COPY_AND_ASSIGN(GpuServiceImpl);
+ DISALLOW_COPY_AND_ASSIGN(GpuServiceProxy);
};
} // namespace ui
-#endif // SERVICES_UI_GPU_GPU_SERVICE_IMPL_H_
+#endif // SERVICES_UI_WS_GPU_SERVICE_PROXY_H_
« no previous file with comments | « services/ui/ws/BUILD.gn ('k') | services/ui/ws/gpu_service_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698