services/ui: Introduce mojom.GpuServiceInternal.

services/ui: Introduce mojom.GpuServiceInternal.

Introduce mojom.GpuServiceInternal interface, which GpuServiceProxy
in window server uses to communicate to GpuServiceInternal in the gpu
process.

BUG=613366
Committed: https://crrev.com/ad8b21be9a81771d3213a603174c228644d35516
Cr-Commit-Position: refs/heads/master@{#414603}

[sadrul, 2016-08-24 17:11:23]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 17:12:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 17:17:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 17:17:10]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[sadrul, 2016-08-24 17:20:15]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 17:20:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-24 17:22:49]

Description was changed from

==========
[wip] services/ui: ...

BUG=
==========

to

==========
services/ui: Introduce mojom.GpuServiceInternal.

Introduce mojom.GpuServiceInternal interface, which GpuServiceProxy
in window server uses to communicate to GpuServiceInternal in the gpu
process.

BUG=613366
==========

[commit-bot: I haz the power, 2016-08-24 17:27:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 17:27:17]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sadrul, 2016-08-24 17:32:37]

sadrul@chromium.org changed reviewers:
+ fsamuel@chromium.org, rjkroege@chromium.org

[sadrul, 2016-08-24 17:32:38]

Another small step after https://codereview.chromium.org/2276433004/

GpuServiceInternal needs to be split up. Working on that as the next step.

[Fady Samuel, 2016-08-24 17:35:51]

lgtm

[sadrul, 2016-08-24 20:04:48]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 20:05:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-24 20:18:08]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 20:18:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-24 20:19:38]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2016-08-24 20:19:39]

+sky@ for owner

[sky, 2016-08-24 20:36:56]

https://codereview.chromium.org/2276963002/diff/60001/services/ui/gpu/interfa...
File services/ui/gpu/interfaces/gpu_service_internal.mojom (right):

https://codereview.chromium.org/2276963002/diff/60001/services/ui/gpu/interfa...
services/ui/gpu/interfaces/gpu_service_internal.mojom:14: // GPUInfo.
Update this as GpuInfo comes from Initialize. Is there a reason you need a
separate Initialize() and not a single EstablishGpuChannel that does the
implicit initialize?

[sadrul, 2016-08-24 21:17:26]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[sadrul, 2016-08-24 21:17:40]

https://codereview.chromium.org/2276963002/diff/60001/services/ui/gpu/interfa...
File services/ui/gpu/interfaces/gpu_service_internal.mojom (right):

https://codereview.chromium.org/2276963002/diff/60001/services/ui/gpu/interfa...
services/ui/gpu/interfaces/gpu_service_internal.mojom:14: // GPUInfo.
On 2016/08/24 20:36:56, sky wrote:
> Update this as GpuInfo comes from Initialize. Is there a reason you need a
> separate Initialize() and not a single EstablishGpuChannel that does the
> implicit initialize?

Updated the doc.

EstablishGpuChannel() is called once for each client, but Initialize() needs to
happen just once.

[commit-bot: I haz the power, 2016-08-24 21:18:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-24 21:38:31]

sadrul@chromium.org changed reviewers:
+ piman@chromium.org

[sadrul, 2016-08-24 21:38:32]

+piman@ for DEPS on +gpu/config

[piman, 2016-08-24 21:48:15]

lgtm

[rjkroege, 2016-08-24 22:45:43]

lgtm

[commit-bot: I haz the power, 2016-08-24 22:48:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 22:48:33]

Dry run: This issue passed the CQ dry run.

[sky, 2016-08-24 23:38:38]

Ok, LGTM

[sadrul, 2016-08-25 03:33:56]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-08-25 03:33:57]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2276963002/#ps80001
(title: ".")

[commit-bot: I haz the power, 2016-08-25 03:34:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-25 03:38:43]

sadrul@chromium.org changed reviewers:
+ tsepez@chromium.org

[sadrul, 2016-08-25 03:38:44]

+tsepez@ for mojom

[commit-bot: I haz the power, 2016-08-25 03:43:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 03:43:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Tom Sepez, 2016-08-25 17:14:24]

https://codereview.chromium.org/2276963002/diff/80001/services/ui/gpu/interfa...
File services/ui/gpu/interfaces/gpu_service_internal.mojom (right):

https://codereview.chromium.org/2276963002/diff/80001/services/ui/gpu/interfa...
services/ui/gpu/interfaces/gpu_service_internal.mojom:14: EstablishGpuChannel()
=> (int32 client_id,
Whenever an ID is introduced, the question is "what happens when an untrusted
client hands back a spoofed one later on?"

[sadrul, 2016-08-25 20:40:49]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[sadrul, 2016-08-25 20:41:25]

Patchset #6 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-08-25 20:41:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 20:47:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 20:47:09]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-08-25 21:58:25]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 21:59:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-25 22:03:13]

https://codereview.chromium.org/2276963002/diff/80001/services/ui/gpu/interfa...
File services/ui/gpu/interfaces/gpu_service_internal.mojom (right):

https://codereview.chromium.org/2276963002/diff/80001/services/ui/gpu/interfa...
services/ui/gpu/interfaces/gpu_service_internal.mojom:14: EstablishGpuChannel()
=> (int32 client_id,
On 2016/08/25 17:14:24, Tom Sepez wrote:
> Whenever an ID is introduced, the question is "what happens when an untrusted
> client hands back a spoofed one later on?"

Hm, good point. I have reworked this so the client-id is an input parameter,
instead of an output parameter.

This GpuServiceInternal is a communication channel between the window server,
and the gpu process. i.e. untrusted clients cannot communicate to the gpu
process over this channel. The window-server is the one that assigns a
client-id, instead of the gpu process generating an id from here.
This is equivalent to the client-id currently used in the
GpuMsg_EstablishChannel in chrome:
https://cs.chromium.org/chromium/src/content/common/gpu_host_messages.h?sq=pa...).

[Tom Sepez, 2016-08-25 22:13:49]

OK, LGTM since we are going from a more trusted process into a less trusted one.

[sadrul, 2016-08-25 23:01:02]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-08-25 23:01:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, rjkroege@chromium.org, sky@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2276963002/#ps120001
(title: ".")

[commit-bot: I haz the power, 2016-08-25 23:01:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 00:45:28]

Description was changed from

==========
services/ui: Introduce mojom.GpuServiceInternal.

Introduce mojom.GpuServiceInternal interface, which GpuServiceProxy
in window server uses to communicate to GpuServiceInternal in the gpu
process.

BUG=613366
==========

to

==========
services/ui: Introduce mojom.GpuServiceInternal.

Introduce mojom.GpuServiceInternal interface, which GpuServiceProxy
in window server uses to communicate to GpuServiceInternal in the gpu
process.

BUG=613366
==========

[commit-bot: I haz the power, 2016-08-26 00:45:29]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-08-26 00:47:36]

Description was changed from

==========
services/ui: Introduce mojom.GpuServiceInternal.

Introduce mojom.GpuServiceInternal interface, which GpuServiceProxy
in window server uses to communicate to GpuServiceInternal in the gpu
process.

BUG=613366
==========

to

==========
services/ui: Introduce mojom.GpuServiceInternal.

Introduce mojom.GpuServiceInternal interface, which GpuServiceProxy
in window server uses to communicate to GpuServiceInternal in the gpu
process.

BUG=613366

Committed: https://crrev.com/ad8b21be9a81771d3213a603174c228644d35516
Cr-Commit-Position: refs/heads/master@{#414603}
==========

[commit-bot: I haz the power, 2016-08-26 00:47:37]

Patchset 6 (id:??) landed as
https://crrev.com/ad8b21be9a81771d3213a603174c228644d35516
Cr-Commit-Position: refs/heads/master@{#414603}