Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2274573004: Replace ASSERT*() with DCHECK*() in core/xml/. (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
kojii
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews, dominicc+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT*() with DCHECK*() in core/xml/. This CL has no behavior changes. BUG=596760 Committed: https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017 Cr-Commit-Position: refs/heads/master@{#413971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -80 lines) Patch
M third_party/WebKit/Source/core/xml/DocumentXSLT.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/DocumentXSLT.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XMLSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XPathFunctions.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathNodeSet.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathParser.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathPredicate.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathResult.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathStep.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathStep.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathUtil.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XPathValue.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XPathVariableReference.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLImportRule.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLImportRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLStyleSheet.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XSLStyleSheetLibxslt.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/xml/XSLTExtensions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLTProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/parser/MarkupTokenizerInlines.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp View 18 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
kojii@, would you review this please?
4 years, 4 months ago (2016-08-24 01:54:53 UTC) #7
kojii
lgtm
4 years, 4 months ago (2016-08-24 02:03:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274573004/1
4 years, 4 months ago (2016-08-24 03:36:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 03:41:26 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 03:43:31 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23d946cd78876b44e611fbab188a66f80cfd9017
Cr-Commit-Position: refs/heads/master@{#413971}

Powered by Google App Engine
This is Rietveld 408576698