Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: third_party/WebKit/Source/core/xml/XPathStep.cpp

Issue 2274573004: Replace ASSERT*() with DCHECK*() in core/xml/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/xml/XPathStep.h ('k') | third_party/WebKit/Source/core/xml/XPathUtil.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/xml/XPathStep.cpp
diff --git a/third_party/WebKit/Source/core/xml/XPathStep.cpp b/third_party/WebKit/Source/core/xml/XPathStep.cpp
index b2008e7290d09768c13a8da5810a6054af5b2d78..bf86e065e5c8ae5ad049cbac3414c32c5b67d940 100644
--- a/third_party/WebKit/Source/core/xml/XPathStep.cpp
+++ b/third_party/WebKit/Source/core/xml/XPathStep.cpp
@@ -90,8 +90,8 @@ bool optimizeStepPair(Step* first, Step* second)
&& !first->m_predicates.size()
&& !first->nodeTest().mergedPredicates().size()) {
- ASSERT(first->nodeTest().data().isEmpty());
- ASSERT(first->nodeTest().namespaceURI().isEmpty());
+ DCHECK(first->nodeTest().data().isEmpty());
+ DCHECK(first->nodeTest().namespaceURI().isEmpty());
// Optimize the common case of "//" AKA
// /descendant-or-self::node()/child::NodeTest to /descendant::NodeTest.
@@ -227,7 +227,7 @@ static inline bool nodeMatchesBasicTest(Node* node, Step::Axis axis, const Step:
return element.hasLocalName(name) && namespaceURI == element.namespaceURI();
}
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return false;
}
@@ -257,7 +257,7 @@ static inline bool nodeMatches(EvaluationContext& evaluationContext, Node* node,
// predicates) is applied.
void Step::nodesInAxis(EvaluationContext& evaluationContext, Node* context, NodeSet& nodes) const
{
- ASSERT(nodes.isEmpty());
+ DCHECK(nodes.isEmpty());
switch (m_axis) {
case ChildAxis:
// In XPath model, attribute nodes do not have children.
@@ -431,7 +431,7 @@ void Step::nodesInAxis(EvaluationContext& evaluationContext, Node* context, Node
return;
}
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
} // namespace XPath
« no previous file with comments | « third_party/WebKit/Source/core/xml/XPathStep.h ('k') | third_party/WebKit/Source/core/xml/XPathUtil.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698