Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: third_party/WebKit/Source/core/xml/XPathParser.cpp

Issue 2274573004: Replace ASSERT*() with DCHECK*() in core/xml/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/xml/XPathParser.cpp
diff --git a/third_party/WebKit/Source/core/xml/XPathParser.cpp b/third_party/WebKit/Source/core/xml/XPathParser.cpp
index c44cbba1446db6b1794bd4da0dffe3f82bab7e28..500b921cf511b499a01e49c7f60503debabd6bb3 100644
--- a/third_party/WebKit/Source/core/xml/XPathParser.cpp
+++ b/third_party/WebKit/Source/core/xml/XPathParser.cpp
@@ -486,7 +486,7 @@ Expression* Parser::parseStatement(const String& statement, XPathNSResolver* res
exceptionState.throwDOMException(SyntaxError, "The string '" + statement + "' is not a valid XPath expression.");
return nullptr;
}
- ASSERT(m_strings.size() == 0);
+ DCHECK_EQ(m_strings.size(), 0u);
Expression* result = m_topExpr;
m_topExpr = nullptr;
@@ -495,20 +495,18 @@ Expression* Parser::parseStatement(const String& statement, XPathNSResolver* res
void Parser::registerString(String* s)
{
- if (s == 0)
+ if (!s)
return;
- ASSERT(!m_strings.contains(s));
-
+ DCHECK(!m_strings.contains(s));
m_strings.add(wrapUnique(s));
}
void Parser::deleteString(String* s)
{
- if (s == 0)
+ if (!s)
return;
- ASSERT(m_strings.contains(s));
-
+ DCHECK(m_strings.contains(s));
m_strings.remove(s);
}
« no previous file with comments | « third_party/WebKit/Source/core/xml/XPathNodeSet.cpp ('k') | third_party/WebKit/Source/core/xml/XPathPredicate.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698