Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: third_party/WebKit/Source/core/xml/XPathPredicate.cpp

Issue 2274573004: Replace ASSERT*() with DCHECK*() in core/xml/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/xml/XPathPredicate.cpp
diff --git a/third_party/WebKit/Source/core/xml/XPathPredicate.cpp b/third_party/WebKit/Source/core/xml/XPathPredicate.cpp
index 8099390020d887231852d2e59c43709b7f79d908..9f0a6d6870f224cd5919dc72b277595aa88ae755 100644
--- a/third_party/WebKit/Source/core/xml/XPathPredicate.cpp
+++ b/third_party/WebKit/Source/core/xml/XPathPredicate.cpp
@@ -101,7 +101,7 @@ Value NumericOp::evaluate(EvaluationContext& context) const
case OP_Mod:
return fmod(leftVal, rightVal);
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return 0.0;
}
@@ -164,7 +164,7 @@ bool EqTestOp::compare(EvaluationContext& context, const Value& lhs, const Value
// function is true.
return compare(context, lhs.toBoolean(), rhs);
}
- ASSERT(0);
+ NOTREACHED();
}
if (rhs.isNodeSet()) {
const NodeSet& rhsSet = rhs.toNodeSet(&context);
@@ -184,7 +184,7 @@ bool EqTestOp::compare(EvaluationContext& context, const Value& lhs, const Value
}
if (lhs.isBoolean())
return compare(context, lhs, rhs.toBoolean());
- ASSERT(0);
+ NOTREACHED();
}
// Neither side is a NodeSet.
@@ -211,7 +211,7 @@ bool EqTestOp::compare(EvaluationContext& context, const Value& lhs, const Value
case OpcodeLessOrEqual:
return lhs.toNumber() <= rhs.toNumber();
}
- ASSERT(0);
+ NOTREACHED();
return false;
}
@@ -285,7 +285,7 @@ DEFINE_TRACE(Predicate)
bool Predicate::evaluate(EvaluationContext& context) const
{
- ASSERT(m_expr);
+ DCHECK(m_expr);
Value result(m_expr->evaluate(context));
« no previous file with comments | « third_party/WebKit/Source/core/xml/XPathParser.cpp ('k') | third_party/WebKit/Source/core/xml/XPathResult.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698