third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp - Issue 2274573004: Replace ASSERT*() with DCHECK*() in core/xml/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

Issue 2274573004: Replace ASSERT*() with DCHECK*() in core/xml/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

diff --git a/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp b/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

index 65401f06b1c01075bc1b60b188d6a0593e0c4d6e..4fc8a9d5857946f36a8afa3f3ba51b291acc2051 100644

--- a/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

+++ b/third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp

@@ -155,7 +155,7 @@ static int writeToStringBuilder(void* context, const char* buffer, int len)

const char* stringCurrent = buffer;

WTF::Unicode::ConversionResult result = WTF::Unicode::convertUTF8ToUTF16(&stringCurrent, buffer + len, &bufferUChar, bufferUCharEnd);

if (result != WTF::Unicode::conversionOK && result != WTF::Unicode::sourceExhausted) {

- ASSERT_NOT_REACHED();

+ NOTREACHED();

return -1;

}