ash: Move more code from Shelf to WmShelf

ash: Move more code from Shelf to WmShelf

This is another step toward eliminating ash::Shelf.

* Move code that needs ShelfView into ShelfWidget to avoid exposing ShelfView
* Remove dead code (especially shelf_navigator.*)
* Make icon activation functions static

BUG=615502
TEST=ash_unittests, browser_tests

Committed: https://crrev.com/8fd4ac5bbce4fbdc921a10ed70a7f6360de99c9e
Cr-Commit-Position: refs/heads/master@{#414290}

[James Cook, 2016-08-24 23:42:29]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 23:43:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-08-24 23:44:24]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-08-24 23:44:25]

msw, please take a look.

https://codereview.chromium.org/2274333002/diff/20001/ash/common/shelf/shelf.h
File ash/common/shelf/shelf.h (left):

https://codereview.chromium.org/2274333002/diff/20001/ash/common/shelf/shelf....
ash/common/shelf/shelf.h:55: gfx::Rect
GetScreenBoundsOfItemIconForWindow(WmWindow* window);
moved to ShelfWidget

https://codereview.chromium.org/2274333002/diff/20001/ash/common/shelf/shelf....
ash/common/shelf/shelf.h:63: void ActivateShelfItem(int index);
moved to WmShelf

https://codereview.chromium.org/2274333002/diff/20001/ash/common/shelf/shelf....
ash/common/shelf/shelf.h:66: void CycleWindowLinear(CycleDirection direction);
dead code

https://codereview.chromium.org/2274333002/diff/20001/ash/common/shelf/shelf....
ash/common/shelf/shelf.h:89: void UpdateShelfItemBackground(int alpha);
dead

https://codereview.chromium.org/2274333002/diff/20001/ash/wm/window_animation...
File ash/wm/window_animations.cc (left):

https://codereview.chromium.org/2274333002/diff/20001/ash/wm/window_animation...
ash/wm/window_animations.cc:441: if (!shelf)
This function shouldn't be called from the login screen, and even if it is then
GetScreenBoundsOfItemIconForWindow() will return gfx::Rect() and things will
work fine.

[msw, 2016-08-25 00:22:25]

lgtm with nits

https://codereview.chromium.org/2274333002/diff/20001/ash/common/shelf/wm_she...
File ash/common/shelf/wm_shelf.h (right):

https://codereview.chromium.org/2274333002/diff/20001/ash/common/shelf/wm_she...
ash/common/shelf/wm_shelf.h:116: static void LaunchAppAtIndex(int item_index);
nit: converge on (*AppAtIndex or *ShelfItem) and (|index| or |item_index|)

https://codereview.chromium.org/2274333002/diff/20001/ash/wm/window_animation...
File ash/wm/window_animations.cc (left):

https://codereview.chromium.org/2274333002/diff/20001/ash/wm/window_animation...
ash/wm/window_animations.cc:441: if (!shelf)
On 2016/08/24 23:44:25, James Cook wrote:
> This function shouldn't be called from the login screen, and even if it is
then
> GetScreenBoundsOfItemIconForWindow() will return gfx::Rect() and things will
> work fine.

Acknowledged.

https://codereview.chromium.org/2274333002/diff/20001/chrome/browser/ui/ash/l...
File
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/2274333002/diff/20001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc:90:
// Make the call sites cleaner. C++ "using" doesn't work on methods.
optional nit: I'd just inline 'ash::WmShelf::'.

[commit-bot: I haz the power, 2016-08-25 02:25:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 02:25:01]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-08-25 02:29:13]

Thanks for the quick review.

https://codereview.chromium.org/2274333002/diff/20001/ash/common/shelf/wm_she...
File ash/common/shelf/wm_shelf.h (right):

https://codereview.chromium.org/2274333002/diff/20001/ash/common/shelf/wm_she...
ash/common/shelf/wm_shelf.h:116: static void LaunchAppAtIndex(int item_index);
On 2016/08/25 00:22:24, msw wrote:
> nit: converge on (*AppAtIndex or *ShelfItem) and (|index| or |item_index|)

Done.

https://codereview.chromium.org/2274333002/diff/20001/chrome/browser/ui/ash/l...
File
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/2274333002/diff/20001/chrome/browser/ui/ash/l...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc:90:
// Make the call sites cleaner. C++ "using" doesn't work on methods.
On 2016/08/25 00:22:24, msw wrote:
> optional nit: I'd just inline 'ash::WmShelf::'.

Done.

[James Cook, 2016-08-25 02:29:28]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-08-25 02:29:28]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2274333002/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2016-08-25 02:30:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 03:33:13]

Description was changed from

==========
ash: Move more code from Shelf to WmShelf

This is another step toward eliminating ash::Shelf.

* Move code that needs ShelfView into ShelfWidget to avoid exposing ShelfView
* Remove dead code (especially shelf_navigator.*)
* Make icon activation functions static

BUG=615502
TEST=ash_unittests, browser_tests
==========

to

==========
ash: Move more code from Shelf to WmShelf

This is another step toward eliminating ash::Shelf.

* Move code that needs ShelfView into ShelfWidget to avoid exposing ShelfView
* Remove dead code (especially shelf_navigator.*)
* Make icon activation functions static

BUG=615502
TEST=ash_unittests, browser_tests

Committed: https://crrev.com/8fd4ac5bbce4fbdc921a10ed70a7f6360de99c9e
Cr-Commit-Position: refs/heads/master@{#414290}
==========

[commit-bot: I haz the power, 2016-08-25 03:33:14]

Patchset 3 (id:??) landed as
https://crrev.com/8fd4ac5bbce4fbdc921a10ed70a7f6360de99c9e
Cr-Commit-Position: refs/heads/master@{#414290}