Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: ash/common/shelf/shelf.h

Issue 2274333002: ash: Move more code from Shelf to WmShelf (Closed)
Patch Set: review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/ash.gyp ('k') | ash/common/shelf/shelf.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shelf/shelf.h
diff --git a/ash/common/shelf/shelf.h b/ash/common/shelf/shelf.h
index c70264a032ea7c98bf0cf7d04aa84fbc9fe04192..233a5065242c88fe6c2f998844ee4c1755550520 100644
--- a/ash/common/shelf/shelf.h
+++ b/ash/common/shelf/shelf.h
@@ -6,8 +6,6 @@
#define ASH_COMMON_SHELF_SHELF_H_
#include "ash/ash_export.h"
-#include "ash/common/shelf/shelf_constants.h"
-#include "ash/common/shelf/shelf_types.h"
#include "ash/common/shelf/shelf_widget.h"
#include "base/macros.h"
@@ -50,27 +48,8 @@ class ASH_EXPORT Shelf {
// TODO(jamescook): Remove this.
WmShelf* wm_shelf() { return wm_shelf_; }
- // Returns the screen bounds of the item for the specified window. If there is
- // no item for the specified window an empty rect is returned.
- gfx::Rect GetScreenBoundsOfItemIconForWindow(WmWindow* window);
-
- // Updates the icon position given the current window bounds. This is used
- // when dragging panels to reposition them with respect to the other panels.
- void UpdateIconPositionForWindow(WmWindow* window);
-
- // Activates the the shelf item specified by the index in the list of shelf
- // items.
- void ActivateShelfItem(int index);
-
- // Cycles the window focus linearly over the current shelf items.
- void CycleWindowLinear(CycleDirection direction);
-
AppListButton* GetAppListButton() const;
- // Launch a 0-indexed shelf item in the shelf.
- // A negative index launches the last shelf item in the shelf.
- void LaunchAppIndexAt(int item_index);
-
ShelfWidget* shelf_widget() { return shelf_widget_; }
// TODO(msw): ShelfLayoutManager should not be accessed externally.
@@ -78,16 +57,9 @@ class ASH_EXPORT Shelf {
return shelf_widget_->shelf_layout_manager();
}
- // Returns rectangle bounding all visible shelf items. Used screen coordinate
- // system.
- gfx::Rect GetVisibleItemsBoundsInScreen() const;
-
// Returns ApplicationDragAndDropHost for this shelf.
app_list::ApplicationDragAndDropHost* GetDragAndDropHostForAppList();
- // Updates the background for the shelf items.
- void UpdateShelfItemBackground(int alpha);
-
ShelfView* shelf_view_for_testing() { return shelf_view_; }
private:
« no previous file with comments | « ash/ash.gyp ('k') | ash/common/shelf/shelf.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698