Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2273203004: Converted Observatory persistent-hangles-page element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Removed commented code #

Patch Set 3 : Fixed finalizer name visualization #

Total comments: 2

Patch Set 4 : Addressed comments and fixed style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+458 lines, -282 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 2 chunks +18 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/allocation_profile.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile_table.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 3 2 chunks +65 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/error_ref_wrapper.dart View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/heap_snapshot.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/helpers/uris.dart View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/persistent_handles.dart View 1 2 3 1 chunk +235 lines, -139 lines 0 comments Download
D runtime/observatory/lib/src/elements/persistent_handles.html View 1 chunk +0 lines, -105 lines 0 comments Download
A runtime/observatory/lib/src/models/objects/persistent_handles.dart View 1 chunk +21 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/persistent_handles.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/repositories/persistent_handles.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 chunk +33 lines, -0 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/objects/persistent_handles.dart View 1 chunk +32 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/repositories/persistent_handles.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/persistent_handles_page/element_test.dart View 1 chunk +9 lines, -15 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/persistent_handles_page/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
cbernaschina
4 years, 3 months ago (2016-08-25 22:13:50 UTC) #2
cbernaschina
4 years, 3 months ago (2016-08-25 22:20:06 UTC) #3
Cutch
LGTM w/c but wait for Ryan/Todd's LGTM too. https://codereview.chromium.org/2273203004/diff/40001/runtime/observatory/lib/src/elements/persistent_handles.dart File runtime/observatory/lib/src/elements/persistent_handles.dart (right): https://codereview.chromium.org/2273203004/diff/40001/runtime/observatory/lib/src/elements/persistent_handles.dart#newcode129 runtime/observatory/lib/src/elements/persistent_handles.dart:129: List<Element> ...
4 years, 3 months ago (2016-08-25 22:27:28 UTC) #4
cbernaschina
https://codereview.chromium.org/2273203004/diff/40001/runtime/observatory/lib/src/elements/persistent_handles.dart File runtime/observatory/lib/src/elements/persistent_handles.dart (right): https://codereview.chromium.org/2273203004/diff/40001/runtime/observatory/lib/src/elements/persistent_handles.dart#newcode129 runtime/observatory/lib/src/elements/persistent_handles.dart:129: List<Element> _createPersistendHandlers() { On 2016/08/25 22:27:28, Cutch wrote: > ...
4 years, 3 months ago (2016-08-25 22:43:39 UTC) #5
rmacnak
lgtm
4 years, 3 months ago (2016-08-26 16:49:08 UTC) #6
cbernaschina
4 years, 3 months ago (2016-08-26 17:15:42 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
12e8f86cf66f653f6a759486b4bbdb26e39463ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698