Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: runtime/observatory/tests/observatory_ui/persistent_handles_page/element_test.dart

Issue 2273203004: Converted Observatory persistent-hangles-page element (Closed)
Patch Set: Addressed comments and fixed style Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/persistent_handles_page/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/ports/element_test.dart b/runtime/observatory/tests/observatory_ui/persistent_handles_page/element_test.dart
similarity index 61%
copy from runtime/observatory/tests/observatory_ui/ports/element_test.dart
copy to runtime/observatory/tests/observatory_ui/persistent_handles_page/element_test.dart
index 9f7807b83862af695f56e662eb5e5e061922f255..f2e4b848742a71698a3e0a7dca4bb750542e37ab 100644
--- a/runtime/observatory/tests/observatory_ui/ports/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/persistent_handles_page/element_test.dart
@@ -4,43 +4,37 @@
import 'dart:html';
import 'package:unittest/unittest.dart';
-import 'package:observatory/src/elements/ports.dart';
+import 'package:observatory/src/elements/persistent_handles.dart';
import '../mocks.dart';
main() {
- PortsElement.tag.ensureRegistration();
+ PersistentHandlesPageElement.tag.ensureRegistration();
const vm = const VMMock();
const isolate = const IsolateRefMock();
final events = new EventRepositoryMock();
final notifs = new NotificationRepositoryMock();
- final ports = new PortsRepositoryMock();
+ final repository = new PersistentHandlesRepositoryMock();
final instances = new InstanceRepositoryMock();
test('instantiation', () {
- final e = new PortsElement(vm, isolate, events, notifs, ports, instances);
+ final e = new PersistentHandlesPageElement(vm, isolate, events, notifs,
+ repository, instances);
expect(e, isNotNull, reason: 'element correctly created');
expect(e.isolate, equals(isolate));
- expect(e.ports, equals(ports));
});
test('elements created after attachment', () async {
- const elements = const [
- const PortMock(name: 'port-1'),
- const PortMock(name: 'port-2'),
- const PortMock(name: 'port-3')
- ];
- const isolatePorts = const PortsMock(elements: elements);
- final ports = new PortsRepositoryMock(
+ final repository = new PersistentHandlesRepositoryMock(
getter: expectAsync((i) async {
expect(i, equals(isolate));
- return isolatePorts;
+ return const PersistentHandlesMock();
}, count: 1)
);
final instances = new InstanceRepositoryMock();
- final e = new PortsElement(vm, isolate, events, notifs, ports, instances);
+ final e = new PersistentHandlesPageElement(vm, isolate, events, notifs,
+ repository, instances);
document.body.append(e);
await e.onRendered.first;
expect(e.children.length, isNonZero, reason: 'has elements');
- expect(e.querySelectorAll('.port-number').length, equals(elements.length));
e.remove();
await e.onRendered.first;
expect(e.children.length, isZero, reason: 'is empty');

Powered by Google App Engine
This is Rietveld 408576698