Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2273203004: Converted Observatory persistent-hangles-page element (Closed)
Patch Set: Addressed comments and fixed style Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index bad6c88d2d1d65ebc7b34433f7db8926e868ee76..b6bda732f4190dcf66e25e6ffeb12603d6716b4a 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -15,6 +15,8 @@ InboundReferencesRepository _inboundReferencesRepository
InstanceRepository _instanceRepository = new InstanceRepository();
IsolateSampleProfileRepository _isolateSampleProfileRepository
= new IsolateSampleProfileRepository();
+PersistentHandlesRepository _persistentHandlesRepository
+ = new PersistentHandlesRepository();
PortsRepository _portsRepository = new PortsRepository();
class IsolateNotFound implements Exception {
@@ -374,19 +376,28 @@ class PortsPage extends MatchingPage {
}
}
-class PersistentHandlesPage extends SimplePage {
- PersistentHandlesPage(app)
- : super('persistent-handles', 'persistent-handles-page', app);
+class PersistentHandlesPage extends MatchingPage {
+ PersistentHandlesPage(app) : super('persistent-handles', app);
+
+ final DivElement container = new DivElement();
void _visit(Uri uri) {
super._visit(uri);
getIsolate(uri).then((isolate) {
- if (element != null) {
- PersistentHandlesPageElement page = element;
- page.isolate = isolate;
- }
+ container.children = [
+ new PersistentHandlesPageElement(isolate.vm, isolate, app.events,
+ app.notifications,
+ _persistentHandlesRepository,
+ _instanceRepository, queue: app.queue)
+ ];
});
}
+
+ void onInstall() {
+ if (element == null) {
+ element = container;
+ }
+ }
}
class HeapMapPage extends SimplePage {
« no previous file with comments | « runtime/observatory/lib/repositories.dart ('k') | runtime/observatory/lib/src/elements/allocation_profile.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698