runtime/observatory/lib/src/elements/heap_snapshot.dart - Issue 2273203004: Converted Observatory persistent-hangles-page element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/heap_snapshot.dart

Issue 2273203004: Converted Observatory persistent-hangles-page element (Closed)

Patch Set: Addressed comments and fixed style Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/elements/heap_snapshot.dart

diff --git a/runtime/observatory/lib/src/elements/heap_snapshot.dart b/runtime/observatory/lib/src/elements/heap_snapshot.dart

index 0913e1ebdb257784f40a1b1f634caa57f11a01fe..e0771eb8fa4ed8a9e58bc611e56687554845a7b2 100644

--- a/runtime/observatory/lib/src/elements/heap_snapshot.dart

+++ b/runtime/observatory/lib/src/elements/heap_snapshot.dart

@@ -111,7 +111,7 @@ class HeapSnapshotElement extends HtmlElement implements Renderable {

new NavTopMenuElement(queue: _r.queue),

new NavVMMenuElement(_vm, _events, queue: _r.queue),

new NavIsolateMenuElement(_isolate, _events, queue: _r.queue),

- new NavMenuElement('heap snapshot', link: Uris.profiler(_isolate),

+ new NavMenuElement('heap snapshot', link: Uris.heapSnapshot(_isolate),

last: true, queue: _r.queue),

new NavRefreshElement(queue: _r.queue)

..disabled = M.isHeapSnapshotProgressRunning(_progress?.status)