runtime/observatory/lib/src/elements/helpers/uris.dart - Issue 2273203004: Converted Observatory persistent-hangles-page element

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/observatory/lib/src/elements/helpers/uris.dart

Issue 2273203004: Converted Observatory persistent-hangles-page element (Closed)

Patch Set: Addressed comments and fixed style Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 import 'package:observatory/models.dart' as M;	5 import 'package:observatory/models.dart' as M;

6	6

7 /// Utility class for URIs generation.	7 /// Utility class for URIs generation.

8 abstract class Uris {	8 abstract class Uris {

9 static String _isolatePage(String path, M.IsolateRef isolate,	9 static String _isolatePage(String path, M.IsolateRef isolate,

10 {M.ObjectRef object}) {	10 {M.ObjectRef object}) {

(...skipping 24 matching lines...) Expand all Loading...
35 return _isolatePage('/inspect', isolate, object: object) + '---pos=${pos}';	35 return _isolatePage('/inspect', isolate, object: object) + '---pos=${pos}';

36 }	36 }

37 static String logging(M.IsolateRef isolate)	37 static String logging(M.IsolateRef isolate)

38 => _isolatePage('/logging', isolate);	38 => _isolatePage('/logging', isolate);

39 static String metrics(M.IsolateRef isolate)	39 static String metrics(M.IsolateRef isolate)

40 => _isolatePage('/metrics', isolate);	40 => _isolatePage('/metrics', isolate);

41 static String persistentHandles(M.IsolateRef isolate)	41 static String persistentHandles(M.IsolateRef isolate)

42 => _isolatePage('/persistent-handles', isolate);	42 => _isolatePage('/persistent-handles', isolate);

43 static String ports(M.IsolateRef isolate)	43 static String ports(M.IsolateRef isolate)

44 => _isolatePage('/ports', isolate);	44 => _isolatePage('/ports', isolate);

45 static String profiler(M.IsolateRef isolate)

46 => _isolatePage('/profiler', isolate);

47 static String vm() => '#/vm';	45 static String vm() => '#/vm';

48 static String vmConnect() => '#/vm-connect';	46 static String vmConnect() => '#/vm-connect';

49 }	47 }

OLD	NEW