Fix most chrome/browser/ui "gn check" problems.

Fix most chrome/browser/ui "gn check" problems.

There is one blocking bug that prevents this from being added, but this addresses the other issues.

Aura and Ash hit a "gn check" worst-case which requires lots of //nogncheck annotations.

This also separates out browser.h includes into !OS_ANDROID blocks (previously these includes were unconditional but "Browser" doesn't exist on Android).

R=sky
TBR=dbeam for webui/*

Committed: https://crrev.com/08fe0e95b421f4dec693af537a4ce139fb9cbe9f
Cr-Commit-Position: refs/heads/master@{#414823}

[brettw, 2016-08-25 20:32:28]

Description was changed from

==========
Add chrome/browser/ui to "gn check"
==========

to

==========
Fix most chrome/browser/ui "gn check" problems.

There is one blocking bug that prevents this from being added, but this
addresses the other issues.

Aura and Ash hit a "gn check" worst-case which requires lots of //nogncheck
annotations.

This also separates out browser.h includes into !OS_ANDROID blocks (previously
these includes were unconditional but "Browser" doesn't exist on Android).
==========

[brettw, 2016-08-25 20:32:28]

brettw@chromium.org changed reviewers:
+ sky@chromium.org

[brettw, 2016-08-25 20:32:32]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 20:33:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 20:53:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 20:53:59]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-08-25 20:54:39]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 20:55:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 21:30:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 21:30:09]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[brettw, 2016-08-25 21:50:13]

Drive

[brettw, 2016-08-25 21:50:14]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 21:51:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 22:44:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 22:44:19]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[brettw, 2016-08-25 22:57:14]

Merge

[brettw, 2016-08-25 22:57:15]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 22:57:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 00:10:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 00:10:26]

Dry run: This issue passed the CQ dry run.

[sky, 2016-08-26 20:10:25]

There sure is a lot of ick in here. LGTM

https://codereview.chromium.org/2272173002/diff/80001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2272173002/diff/80001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:471: sources += [ "browser_window.h" ]
ICK! I suspect this is a bug that android is including this file...

[brettw, 2016-08-26 20:14:31]

https://codereview.chromium.org/2272173002/diff/80001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/2272173002/diff/80001/chrome/browser/ui/BUILD...
chrome/browser/ui/BUILD.gn:471: sources += [ "browser_window.h" ]
On 2016/08/26 20:10:25, sky wrote:
> ICK! I suspect this is a bug that android is including this file...

Yes, there is a lot of win.

[brettw, 2016-08-26 20:14:38]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-08-26 20:15:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 20:25:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 20:25:23]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2016-08-26 21:47:05]

Description was changed from

==========
Fix most chrome/browser/ui "gn check" problems.

There is one blocking bug that prevents this from being added, but this
addresses the other issues.

Aura and Ash hit a "gn check" worst-case which requires lots of //nogncheck
annotations.

This also separates out browser.h includes into !OS_ANDROID blocks (previously
these includes were unconditional but "Browser" doesn't exist on Android).
==========

to

==========
Fix most chrome/browser/ui "gn check" problems.

There is one blocking bug that prevents this from being added, but this
addresses the other issues.

Aura and Ash hit a "gn check" worst-case which requires lots of //nogncheck
annotations.

This also separates out browser.h includes into !OS_ANDROID blocks (previously
these includes were unconditional but "Browser" doesn't exist on Android).

R=sky
TBR=dbeam for webui/*
==========

[brettw, 2016-08-26 21:47:05]

brettw@chromium.org changed reviewers:
+ dbeam@chromium.org

[brettw, 2016-08-26 21:47:18]

TBR dbeam for webui

[brettw, 2016-08-26 21:47:25]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-08-26 21:48:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 21:54:02]

Description was changed from

==========
Fix most chrome/browser/ui "gn check" problems.

There is one blocking bug that prevents this from being added, but this
addresses the other issues.

Aura and Ash hit a "gn check" worst-case which requires lots of //nogncheck
annotations.

This also separates out browser.h includes into !OS_ANDROID blocks (previously
these includes were unconditional but "Browser" doesn't exist on Android).

R=sky
TBR=dbeam for webui/*
==========

to

==========
Fix most chrome/browser/ui "gn check" problems.

There is one blocking bug that prevents this from being added, but this
addresses the other issues.

Aura and Ash hit a "gn check" worst-case which requires lots of //nogncheck
annotations.

This also separates out browser.h includes into !OS_ANDROID blocks (previously
these includes were unconditional but "Browser" doesn't exist on Android).

R=sky
TBR=dbeam for webui/*
==========

[commit-bot: I haz the power, 2016-08-26 21:54:04]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-26 21:55:57]

Description was changed from

==========
Fix most chrome/browser/ui "gn check" problems.

There is one blocking bug that prevents this from being added, but this
addresses the other issues.

Aura and Ash hit a "gn check" worst-case which requires lots of //nogncheck
annotations.

This also separates out browser.h includes into !OS_ANDROID blocks (previously
these includes were unconditional but "Browser" doesn't exist on Android).

R=sky
TBR=dbeam for webui/*
==========

to

==========
Fix most chrome/browser/ui "gn check" problems.

There is one blocking bug that prevents this from being added, but this
addresses the other issues.

Aura and Ash hit a "gn check" worst-case which requires lots of //nogncheck
annotations.

This also separates out browser.h includes into !OS_ANDROID blocks (previously
these includes were unconditional but "Browser" doesn't exist on Android).

R=sky
TBR=dbeam for webui/*

Committed: https://crrev.com/08fe0e95b421f4dec693af537a4ce139fb9cbe9f
Cr-Commit-Position: refs/heads/master@{#414823}
==========

[commit-bot: I haz the power, 2016-08-26 21:55:59]

Patchset 5 (id:??) landed as
https://crrev.com/08fe0e95b421f4dec693af537a4ce139fb9cbe9f
Cr-Commit-Position: refs/heads/master@{#414823}