Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2282573002: Remove is_ios conditions from chrome GN build files. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove is_ios conditions from chrome GN build files. The //chrome directory is no longer used by the iOS build so these conditionals are all dead build code. Committed: https://crrev.com/ae8ec0cd30f3dfc584bda5699f4e178e757b8990 Cr-Commit-Position: refs/heads/master@{#414838}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -358 lines) Patch
M chrome/BUILD.gn View 1 2 9 chunks +22 lines, -46 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 19 chunks +172 lines, -221 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 11 chunks +43 lines, -54 lines 0 comments Download
M chrome/common/BUILD.gn View 5 chunks +14 lines, -29 lines 0 comments Download
M chrome/renderer/BUILD.gn View 3 chunks +3 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (11 generated)
brettw
fix
4 years, 3 months ago (2016-08-25 21:40:14 UTC) #1
brettw
4 years, 3 months ago (2016-08-25 21:41:24 UTC) #3
brettw
merge
4 years, 3 months ago (2016-08-25 23:06:12 UTC) #4
brettw
4 years, 3 months ago (2016-08-26 20:19:36 UTC) #13
rohitrao (ping after 24h)
lgtm
4 years, 3 months ago (2016-08-26 20:25:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2282573002/40001
4 years, 3 months ago (2016-08-26 22:34:35 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-26 22:40:32 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 22:43:30 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ae8ec0cd30f3dfc584bda5699f4e178e757b8990
Cr-Commit-Position: refs/heads/master@{#414838}

Powered by Google App Engine
This is Rietveld 408576698