Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1992)

Unified Diff: ui/base/BUILD.gn

Issue 2272173002: Fix most chrome/browser/ui "gn check" problems. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/BUILD.gn
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
index 5accf0ee26e177d3b5ce8cb347a5d6214ca846ee..184a6f78280e07d6c41314b4bee8e2e597e8d08a 100644
--- a/ui/base/BUILD.gn
+++ b/ui/base/BUILD.gn
@@ -23,10 +23,10 @@ build_ime = !is_ios
# the host to load datapack and generate output in a format defined
# by the platform (this is to support notifications).
#
-# Introduce a standalone target that build on both 'host' and 'target'
-# toolset that just build the support to load datapack. The dependency
+# Introduce a standalone target that can build on both 'host' and 'target'
+# toolchains that just builds the support to load datapacks. The dependencies
# should be kept minimal to have to build too many targets with multiple
-# toolsets.
+# toolchains.
component("ui_data_pack") {
sources = [
"resource/data_pack.cc",
@@ -360,6 +360,7 @@ component("base") {
defines = [ "UI_BASE_IMPLEMENTATION" ]
public_deps = [
+ ":ui_data_pack",
":ui_features",
"//base",
"//skia",
@@ -375,7 +376,6 @@ component("base") {
"//net",
"//third_party/icu",
"//third_party/zlib:zlib",
- "//ui/base:ui_data_pack",
"//ui/display",
"//ui/events",
"//ui/events/devices",
« chrome/browser/ui/BUILD.gn ('K') | « components/translate/content/browser/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698