Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: .gn

Issue 2272173002: Fix most chrome/browser/ui "gn check" problems. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | chrome/browser/ui/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # This file is used by the GN meta build system to find the root of the source 1 # This file is used by the GN meta build system to find the root of the source
2 # tree and to set startup options. For documentation on the values set in this 2 # tree and to set startup options. For documentation on the values set in this
3 # file, run "gn help dotfile" at the command line. 3 # file, run "gn help dotfile" at the command line.
4 4
5 # The location of the build configuration file. 5 # The location of the build configuration file.
6 buildconfig = "//build/config/BUILDCONFIG.gn" 6 buildconfig = "//build/config/BUILDCONFIG.gn"
7 7
8 # The secondary source root is a parallel directory tree where 8 # The secondary source root is a parallel directory tree where
9 # GN build files are placed when they can not be placed directly 9 # GN build files are placed when they can not be placed directly
10 # in the source tree, e.g. for third party source trees. 10 # in the source tree, e.g. for third party source trees.
11 secondary_source = "//build/secondary/" 11 secondary_source = "//build/secondary/"
12 12
13 # These are the targets to check headers for by default. The files in targets 13 # These are the targets to check headers for by default. The files in targets
14 # matching these patterns (see "gn help label_pattern" for format) will have 14 # matching these patterns (see "gn help label_pattern" for format) will have
15 # their includes checked for proper dependencies when you run either 15 # their includes checked for proper dependencies when you run either
16 # "gn check" or "gn gen --check". 16 # "gn check" or "gn gen --check".
17 check_targets = [ 17 check_targets = [
18 #"//apps/*", # Medium-hard. 18 #"//apps/*", # Medium-hard.
19 "//ash/*", 19 "//ash/*",
20 "//base/*", 20 "//base/*",
21 "//blimp/*", 21 "//blimp/*",
22 "//blink/*", 22 "//blink/*",
23 "//breakpad/*", 23 "//breakpad/*",
24 "//build/*", 24 "//build/*",
25 "//cc/*", 25 "//cc/*",
26 26
27 #"//chrome/*", # Epic number of errors. 27 #"//chrome/*", # Epic number of errors.
28 "//chrome/app/*", 28 "//chrome/app/*",
29 "//chrome/browser/extensions/*", 29 "//chrome/browser/extensions/*",
30
31 #"//chrome/browser/ui/*", # Just a few things left
30 "//chrome/common/*", 32 "//chrome/common/*",
31 "//chrome/installer/*", 33 "//chrome/installer/*",
32 "//chrome/third_party/mozilla_security_manager/*", 34 "//chrome/third_party/mozilla_security_manager/*",
33 "//chrome/tools/*", 35 "//chrome/tools/*",
34 "//chrome/utility/*", 36 "//chrome/utility/*",
35 "//chromecast/*", 37 "//chromecast/*",
36 "//chromeos/*", 38 "//chromeos/*",
37 "//chrome_elf/*", 39 "//chrome_elf/*",
38 "//cloud_print/*", 40 "//cloud_print/*",
39 "//components/*", 41 "//components/*",
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 "//tools/gn/misc/emacs/gn.el", 314 "//tools/gn/misc/emacs/gn.el",
313 "//tools/gn/misc/vim/syntax/gn.vim", 315 "//tools/gn/misc/vim/syntax/gn.vim",
314 "//tools/gn/setup.cc", 316 "//tools/gn/setup.cc",
315 "//ui/accessibility/BUILD.gn", 317 "//ui/accessibility/BUILD.gn",
316 "//ui/gfx/BUILD.gn", 318 "//ui/gfx/BUILD.gn",
317 "//ui/views/BUILD.gn", 319 "//ui/views/BUILD.gn",
318 "//ui/views/mus/BUILD.gn", 320 "//ui/views/mus/BUILD.gn",
319 "//v8/test/cctest/BUILD.gn", 321 "//v8/test/cctest/BUILD.gn",
320 "//v8/test/unittests/BUILD.gn", 322 "//v8/test/unittests/BUILD.gn",
321 ] 323 ]
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/BUILD.gn » ('j') | chrome/browser/ui/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698