Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: chrome/browser/BUILD.gn

Issue 2272173002: Fix most chrome/browser/ui "gn check" problems. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gn ('k') | chrome/browser/ui/BUILD.gn » ('j') | chrome/browser/ui/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 90a476dcc0b4f58f37f0243502e239b680bf04d2..cf783f572117f77fef0bce4db7f6bcbcccfb0e87 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -73,6 +73,7 @@ split_static_library("browser") {
# iOS/non-iOS shared deps. New dependencies should generally be added in the
# non-iOS deps below.
public_deps = [
+ "//chrome/common",
"//components/autofill/core/browser",
"//components/sync",
"//content/public/browser",
@@ -88,7 +89,6 @@ split_static_library("browser") {
"//chrome/browser/metrics/variations:chrome_ui_string_overrider_factory",
"//chrome/browser/net:probe_message_proto",
"//chrome/browser/ui",
- "//chrome/common",
"//components/autofill/core/browser",
"//components/bookmarks/browser",
"//components/bookmarks/managed",
@@ -438,7 +438,7 @@ split_static_library("browser") {
"//chrome/common/extensions/api",
"//chrome/common/extensions/api:api_registration",
"//chrome/common/extensions/api:extensions_features",
- "//components/drive:drive",
+ "//components/drive",
"//components/proximity_auth/ble",
"//components/proximity_auth/cryptauth",
"//extensions/components/javascript_dialog_extensions_client",
@@ -622,6 +622,10 @@ split_static_library("browser") {
} else {
sources -= [ "password_manager/password_store_x.cc" ]
}
+ if (use_aura && !use_ozone && is_desktop_linux) {
+ deps += [ "//chrome/browser/ui/libgtk2ui" ]
+ allow_circular_includes_from += [ "//chrome/browser/ui/libgtk2ui" ]
+ }
if (is_posix && !is_mac && !is_ios) {
sources += [
"//chrome/app/chrome_crash_reporter_client.cc",
« no previous file with comments | « .gn ('k') | chrome/browser/ui/BUILD.gn » ('j') | chrome/browser/ui/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698