Added support for GameController devices on OSX

Added support for GameController devices on OSX

This is Apple's new gamepad API for Mac and iOS devices, which imposes a ridgid
set of guidelines on controller capabilities, similar to XInput on Windows. This
allows us to provide a "standard" mapping for every compatible controller. While
there aren't many on the market right now, it should make us more future proof
and provide better compatibility with newer controllers.

BUG=638588
Committed: https://crrev.com/3b3379eceba787068c53d37c0f1466f2c271d336
Cr-Commit-Position: refs/heads/master@{#414211}

[bajones, 2016-08-24 18:36:54]

bajones@chromium.org changed reviewers:
+ scottmg@chromium.org

[bajones, 2016-08-24 18:36:55]

scottmg@: PTAL! (I know you're not doing much on the gamepad side of things
these days, but you're the only other owner.)

[scottmg, 2016-08-24 18:44:55]

https://codereview.chromium.org/2271353002/diff/1/device/gamepad/game_control...
File device/gamepad/game_controller_data_fetcher_mac.mm (right):

https://codereview.chromium.org/2271353002/diff/1/device/gamepad/game_control...
device/gamepad/game_controller_data_fetcher_mac.mm:59: // This first time we
encounter a gamepad, set it's name, mapping, and
nit: it's -> its

https://codereview.chromium.org/2271353002/diff/1/device/gamepad/game_control...
device/gamepad/game_controller_data_fetcher_mac.mm:88: BUTTON(0,
[extended_gamepad buttonA]);
#include "device/gamepad/gamepad_standard_mappings.h" and use instead of
constants?

https://codereview.chromium.org/2271353002/diff/1/device/gamepad/game_control...
device/gamepad/game_controller_data_fetcher_mac.mm:97: // No start, select, or
thumbstick buttons
Sorry, I should know this, but are [8-11] these guaranteed to be false/0 here,
always?

[bajones, 2016-08-24 21:32:19]

Thanks for the feedback! 

On 2016/08/24 18:44:55, scottmg wrote:
> nit: it's -> its

Derp. Fixed.

> #include "device/gamepad/gamepad_standard_mappings.h" and use instead of
> constants?

Good idea. Fixed.

> Sorry, I should know this, but are [8-11] these guaranteed to be false/0 here,
> always?

Yes. See
https://cs.chromium.org/chromium/src/device/gamepad/gamepad_pad_state_provide...
which clears the gamepad state to 0 during init and
https://cs.chromium.org/chromium/src/device/gamepad/gamepad_provider.cc?l=238,
which clears the state to zero after a pad disconnects and before it can be
returned to another source.

This is actually one of the areas that has changed recently, so don't feel bad
for not knowing off the top of your head. :)

[scottmg, 2016-08-24 22:05:08]

lgtm

[bajones, 2016-08-24 22:16:04]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2016-08-24 22:17:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 00:05:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 00:11:34]

Description was changed from

==========
Added support for GameController devices on OSX

This is Apple's new gamepad API for Mac and iOS devices, which imposes a ridgid
set of guidelines on controller capabilities, similar to XInput on Windows. This
allows us to provide a "standard" mapping for every compatible controller. While
there aren't many on the market right now, it should make us more future proof
and provide better compatibility with newer controllers.

BUG=638588
==========

to

==========
Added support for GameController devices on OSX

This is Apple's new gamepad API for Mac and iOS devices, which imposes a ridgid
set of guidelines on controller capabilities, similar to XInput on Windows. This
allows us to provide a "standard" mapping for every compatible controller. While
there aren't many on the market right now, it should make us more future proof
and provide better compatibility with newer controllers.

BUG=638588

Committed: https://crrev.com/3b3379eceba787068c53d37c0f1466f2c271d336
Cr-Commit-Position: refs/heads/master@{#414211}
==========

[commit-bot: I haz the power, 2016-08-25 00:11:35]

Patchset 2 (id:??) landed as
https://crrev.com/3b3379eceba787068c53d37c0f1466f2c271d336
Cr-Commit-Position: refs/heads/master@{#414211}

[Nico, 2017-07-13 20:13:14]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2017-07-13 20:13:14]

https://codereview.chromium.org/2271353002/diff/20001/device/gamepad/BUILD.gn
File device/gamepad/BUILD.gn (right):

https://codereview.chromium.org/2271353002/diff/20001/device/gamepad/BUILD.gn...
device/gamepad/BUILD.gn:82: cflags = [ "-Wpartial-availability" ]
We add this globally, at least on mac (not on ios, but I think this target isn't
pulled in on ios anyhow). Do you remember why you had to explicitly add this?
Isn't this passed twice for files in this target now?

[bajones1, 2017-07-13 20:29:06]

On 2017/07/13 20:13:14, Nico (vacation Jun 30-Jul 11) wrote:
> https://codereview.chromium.org/2271353002/diff/20001/device/gamepad/BUILD.gn
> File device/gamepad/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2271353002/diff/20001/device/gamepad/BUILD.gn...
> device/gamepad/BUILD.gn:82: cflags = [ "-Wpartial-availability" ]
> We add this globally, at least on mac (not on ios, but I think this target
isn't
> pulled in on ios anyhow). Do you remember why you had to explicitly add this?
> Isn't this passed twice for files in this target now?

I don't remember the details aside from the fact that it wasn't compiling
without it. When was it added globally? If it was in the last 10 months it's
likely we can pull that out.