Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(458)

Issue 227083002: Revert 261966 "make SetReceiveBufferSize and SetSendBufferSize r..." (Closed)

Created:
6 years, 1 month ago by jschuh
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 261966 "make SetReceiveBufferSize and SetSendBufferSize r..." Appears to have broken the following gcm_unit_tests on Mac: DeviceCredentials AckOnLogin AckWhenLimitReachedWithHeartbeat ExpiredTTLOnRestart InitializeExisting SendMessageRMQAckOnReconnect SendMessageRMQOnRestart SendMessageRMQPartialAckOnReconnect SendMessageRMQWithStreamAck http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/39860 > make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) > > TBR=sergeyu,yzshen > R=wtc > BUG=355222 > > Review URL: https://codereview.chromium.org/217573002 TBR=jar@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -281 lines) Patch
M trunk/src/chrome/browser/devtools/adb/android_usb_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/devtools/adb/android_usb_socket.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_tcp.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_test_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_test_utils.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_udp.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_tcp_socket.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M trunk/src/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M trunk/src/jingle/glue/channel_socket_adapter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/jingle/glue/channel_socket_adapter.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M trunk/src/jingle/glue/fake_ssl_client_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/jingle/glue/fake_ssl_client_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/jingle/glue/fake_ssl_client_socket_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/jingle/glue/proxy_resolving_client_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/jingle/glue/proxy_resolving_client_socket.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/jingle/glue/pseudotcp_adapter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/jingle/glue/pseudotcp_adapter.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/jingle/glue/pseudotcp_adapter_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/net/base/net_error_list.h View 1 chunk +2 lines, -10 lines 0 comments Download
M trunk/src/net/dns/address_sorter_posix_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/net/dns/mock_mdns_socket_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/http/http_proxy_client_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/http/http_proxy_client_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/quic/quic_stream_factory.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M trunk/src/net/socket/buffered_write_stream_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/buffered_write_stream_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/client_socket_pool_base_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/socket.h View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/net/socket/socket_test_util.h View 3 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/net/socket/socket_test_util.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M trunk/src/net/socket/socks5_client_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/socks5_client_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/socks_client_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/socks_client_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/ssl_client_socket_nss.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/ssl_client_socket_nss.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/ssl_client_socket_openssl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/ssl_client_socket_openssl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/ssl_client_socket_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/ssl_server_socket_nss.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/ssl_server_socket_nss.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/ssl_server_socket_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/net/socket/tcp_client_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/tcp_client_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/tcp_socket_libevent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/tcp_socket_libevent.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M trunk/src/net/socket/tcp_socket_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/socket/tcp_socket_win.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M trunk/src/net/socket/transport_client_socket_pool_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/net/spdy/spdy_proxy_client_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/spdy/spdy_proxy_client_socket.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M trunk/src/net/udp/datagram_server_socket.h View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/net/udp/udp_client_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/udp/udp_client_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/udp/udp_server_socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/udp/udp_server_socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/udp/udp_socket_libevent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/net/udp/udp_socket_libevent.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M trunk/src/net/udp/udp_socket_win.h View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/net/udp/udp_socket_win.cc View 1 chunk +28 lines, -31 lines 0 comments Download
M trunk/src/remoting/jingle_glue/chromium_socket_factory.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/remoting/protocol/channel_multiplexer.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/remoting/protocol/fake_session.h View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/remoting/protocol/fake_session.cc View 3 chunks +9 lines, -11 lines 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jschuh
6 years, 1 month ago (2014-04-05 13:08:43 UTC) #1
jschuh
Committed patchset #1 manually as r262002 (tree was closed).
6 years, 1 month ago (2014-04-05 13:12:00 UTC) #2
jschuh
6 years, 1 month ago (2014-04-05 14:14:47 UTC) #3
Message was sent while issue was closed.
I'm upgrading "appears" to "confirmed" since the gcm_unit_tests are now all
passing.

Powered by Google App Engine
This is Rietveld 408576698