Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: trunk/src/net/socket/tcp_socket_win.cc

Issue 227083002: Revert 261966 "make SetReceiveBufferSize and SetSendBufferSize r..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/net/socket/tcp_socket_win.cc
===================================================================
--- trunk/src/net/socket/tcp_socket_win.cc (revision 262001)
+++ trunk/src/net/socket/tcp_socket_win.cc (working copy)
@@ -28,20 +28,18 @@
const int kTCPKeepAliveSeconds = 45;
-int SetSocketReceiveBufferSize(SOCKET socket, int32 size) {
+bool SetSocketReceiveBufferSize(SOCKET socket, int32 size) {
int rv = setsockopt(socket, SOL_SOCKET, SO_RCVBUF,
reinterpret_cast<const char*>(&size), sizeof(size));
- int net_error = (rv == 0) ? OK : MapSystemError(WSAGetLastError());
- DCHECK(!rv) << "Could not set socket receive buffer size: " << net_error;
- return net_error;
+ DCHECK(!rv) << "Could not set socket receive buffer size: " << GetLastError();
+ return rv == 0;
}
-int SetSocketSendBufferSize(SOCKET socket, int32 size) {
+bool SetSocketSendBufferSize(SOCKET socket, int32 size) {
int rv = setsockopt(socket, SOL_SOCKET, SO_SNDBUF,
reinterpret_cast<const char*>(&size), sizeof(size));
- int net_error = (rv == 0) ? OK : MapSystemError(WSAGetLastError());
- DCHECK(!rv) << "Could not set socket send buffer size: " << net_error;
- return net_error;
+ DCHECK(!rv) << "Could not set socket send buffer size: " << GetLastError();
+ return rv == 0;
}
// Disable Nagle.
@@ -601,12 +599,12 @@
return OK;
}
-int TCPSocketWin::SetReceiveBufferSize(int32 size) {
+bool TCPSocketWin::SetReceiveBufferSize(int32 size) {
DCHECK(CalledOnValidThread());
return SetSocketReceiveBufferSize(socket_, size);
}
-int TCPSocketWin::SetSendBufferSize(int32 size) {
+bool TCPSocketWin::SetSendBufferSize(int32 size) {
DCHECK(CalledOnValidThread());
return SetSocketSendBufferSize(socket_, size);
}
« no previous file with comments | « trunk/src/net/socket/tcp_socket_win.h ('k') | trunk/src/net/socket/transport_client_socket_pool_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698