Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: trunk/src/content/browser/renderer_host/pepper/pepper_tcp_socket.cc

Issue 227083002: Revert 261966 "make SetReceiveBufferSize and SetSendBufferSize r..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/renderer_host/pepper/pepper_tcp_socket.cc
===================================================================
--- trunk/src/content/browser/renderer_host/pepper/pepper_tcp_socket.cc (revision 262001)
+++ trunk/src/content/browser/renderer_host/pepper/pepper_tcp_socket.cc (working copy)
@@ -254,22 +254,21 @@
return;
}
- int net_result = net::OK;
+ bool result = false;
if (name == PP_TCPSOCKET_OPTION_SEND_BUFFER_SIZE) {
if (integer_value > ppapi::TCPSocketShared::kMaxSendBufferSize) {
SendSetOptionACK(PP_ERROR_BADARGUMENT);
return;
}
- net_result = tcp_socket->SetSendBufferSize(integer_value);
+ result = tcp_socket->SetSendBufferSize(integer_value);
} else {
if (integer_value > ppapi::TCPSocketShared::kMaxReceiveBufferSize) {
SendSetOptionACK(PP_ERROR_BADARGUMENT);
return;
}
- net_result = tcp_socket->SetReceiveBufferSize(integer_value);
+ result = tcp_socket->SetReceiveBufferSize(integer_value);
}
- // TODO(wtc): Add error mapping.
- SendSetOptionACK((net_result == net::OK) ? PP_OK : PP_ERROR_FAILED);
+ SendSetOptionACK(result ? PP_OK : PP_ERROR_FAILED);
return;
}
default: {

Powered by Google App Engine
This is Rietveld 408576698