Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Unified Diff: trunk/src/net/socket/socket.h

Issue 227083002: Revert 261966 "make SetReceiveBufferSize and SetSendBufferSize r..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/net/socket/client_socket_pool_base_unittest.cc ('k') | trunk/src/net/socket/socket_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/net/socket/socket.h
===================================================================
--- trunk/src/net/socket/socket.h (revision 262001)
+++ trunk/src/net/socket/socket.h (working copy)
@@ -48,13 +48,13 @@
// Set the receive buffer size (in bytes) for the socket.
// Note: changing this value can affect the TCP window size on some platforms.
- // Returns a net error code.
- virtual int SetReceiveBufferSize(int32 size) = 0;
+ // Returns true on success, or false on failure.
+ virtual bool SetReceiveBufferSize(int32 size) = 0;
// Set the send buffer size (in bytes) for the socket.
// Note: changing this value can affect the TCP window size on some platforms.
- // Returns a net error code.
- virtual int SetSendBufferSize(int32 size) = 0;
+ // Returns true on success, or false on failure.
+ virtual bool SetSendBufferSize(int32 size) = 0;
};
} // namespace net
« no previous file with comments | « trunk/src/net/socket/client_socket_pool_base_unittest.cc ('k') | trunk/src/net/socket/socket_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698