Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: trunk/src/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc

Issue 227083002: Revert 261966 "make SetReceiveBufferSize and SetSendBufferSize r..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc
===================================================================
--- trunk/src/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc (revision 262001)
+++ trunk/src/content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc (working copy)
@@ -140,22 +140,21 @@
if (!value.GetInt32(&integer_value) || integer_value <= 0)
return PP_ERROR_BADARGUMENT;
- int net_result = net::OK;
+ bool result = false;
if (name == PP_UDPSOCKET_OPTION_SEND_BUFFER_SIZE) {
if (integer_value >
ppapi::proxy::UDPSocketResourceBase::kMaxSendBufferSize) {
return PP_ERROR_BADARGUMENT;
}
- net_result = socket_->SetSendBufferSize(integer_value);
+ result = socket_->SetSendBufferSize(integer_value);
} else {
if (integer_value >
ppapi::proxy::UDPSocketResourceBase::kMaxReceiveBufferSize) {
return PP_ERROR_BADARGUMENT;
}
- net_result = socket_->SetReceiveBufferSize(integer_value);
+ result = socket_->SetReceiveBufferSize(integer_value);
}
- // TODO(wtc): Add error mapping code.
- return (net_result == net::OK) ? PP_OK : PP_ERROR_FAILED;
+ return result ? PP_OK : PP_ERROR_FAILED;
}
default: {
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698