Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2269843002: [DevTools] Improve ConsoleAPI functions string description (Closed)

Created:
4 years, 3 months ago by kozy
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Improve ConsoleAPI functions string description BUG=638742 R=dgozman@chromium.org Committed: https://crrev.com/149d9e717953a1979d186a99ef7075e184253bd7 Cr-Commit-Position: refs/heads/master@{#413968}

Patch Set 1 #

Patch Set 2 : replaced ->Set( in v8_inspector #

Total comments: 4

Patch Set 3 #

Patch Set 4 : reverted set console in InspectedContext #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -38 lines) Patch
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp View 1 2 4 chunks +25 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp View 1 2 4 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.cpp View 1 2 3 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
kozy
Dmitry, please take a look!
4 years, 3 months ago (2016-08-23 02:18:35 UTC) #1
dgozman
lgtm. Do we have more Set() calls? Maybe introduce a helper if these are common?
4 years, 3 months ago (2016-08-23 17:49:43 UTC) #2
kozy
Dmitry, please take another look!
4 years, 3 months ago (2016-08-23 18:38:43 UTC) #3
dgozman
https://codereview.chromium.org/2269843002/diff/20001/third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.cpp File third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.cpp (right): https://codereview.chromium.org/2269843002/diff/20001/third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.cpp#newcode92 third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.cpp:92: v8::Isolate::DisallowJavascriptExecutionScope throwJs(context->GetIsolate(), v8::Isolate::DisallowJavascriptExecutionScope::THROW_ON_FAILURE); Let's try/catch this?
4 years, 3 months ago (2016-08-23 19:26:49 UTC) #6
dgozman
https://codereview.chromium.org/2269843002/diff/20001/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right): https://codereview.chromium.org/2269843002/diff/20001/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp#newcode182 third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:182: static v8::Maybe<bool> safeCreateDataProperty(v8::Local<v8::Context> context, v8::Local<v8::Object> object, v8::Local<v8::Name> key, v8::Local<v8::Value> ...
4 years, 3 months ago (2016-08-23 19:27:37 UTC) #7
kozy
All done. Please take a look! https://codereview.chromium.org/2269843002/diff/20001/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right): https://codereview.chromium.org/2269843002/diff/20001/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp#newcode182 third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:182: static v8::Maybe<bool> safeCreateDataProperty(v8::Local<v8::Context> ...
4 years, 3 months ago (2016-08-23 19:33:46 UTC) #8
dgozman
lgtm
4 years, 3 months ago (2016-08-23 20:43:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269843002/40001
4 years, 3 months ago (2016-08-23 20:44:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269843002/40001
4 years, 3 months ago (2016-08-23 21:10:10 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/128197)
4 years, 3 months ago (2016-08-23 22:52:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269843002/60001
4 years, 3 months ago (2016-08-24 00:58:03 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-24 03:22:58 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 03:28:27 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/149d9e717953a1979d186a99ef7075e184253bd7
Cr-Commit-Position: refs/heads/master@{#413968}

Powered by Google App Engine
This is Rietveld 408576698