[DevTools] Improve ConsoleAPI functions string description

third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/V8Console.h"
 
 #include "platform/v8_inspector/InjectedScript.h"
 #include "platform/v8_inspector/InspectedContext.h"
 #include "platform/v8_inspector/V8Compat.h"
 #include "platform/v8_inspector/V8ConsoleMessage.h"
 #include "platform/v8_inspector/V8DebuggerAgentImpl.h"
 #include "platform/v8_inspector/V8InspectorImpl.h"
 #include "platform/v8_inspector/V8InspectorSessionImpl.h"
 #include "platform/v8_inspector/V8ProfilerAgentImpl.h"
 #include "platform/v8_inspector/V8RuntimeAgentImpl.h"
 #include "platform/v8_inspector/V8StackTraceImpl.h"
 #include "platform/v8_inspector/V8StringUtil.h"
+#include "platform/v8_inspector/V8ValueCopier.h"
 #include "platform/v8_inspector/public/V8InspectorClient.h"
 
 namespace v8_inspector {
 
 namespace {
 
 v8::Local<v8::Private> inspectedContextPrivateKey(v8::Isolate* isolate)
 {
     return v8::Private::ForApi(isolate, toV8StringInternalized(isolate, "V8Console#InspectedContext"));
 }
@@ skipping 241 matching lines @@
 {
     v8::Local<v8::String> funcName = toV8StringInternalized(context->GetIsolate(), name);
     v8::Local<v8::Function> func;
     if (!V8_FUNCTION_NEW_REMOVE_PROTOTYPE(context, callback, console, 0).ToLocal(&func))
         return;
     func->SetName(funcName);
     if (description) {
         v8::Local<v8::String> returnValue = toV8String(context->GetIsolate(), description);
         v8::Local<v8::Function> toStringFunction;
         if (V8_FUNCTION_NEW_REMOVE_PROTOTYPE(context, returnDataCallback, returnValue, 0).ToLocal(&toStringFunction))
-            func->Set(toV8StringInternalized(context->GetIsolate(), "toString"), toStringFunction);
+            createDataProperty(context, func, toV8StringInternalized(context->GetIsolate(), "toString"), toStringFunction);
     }
-    if (!console->Set(context, funcName, func).FromMaybe(false))
-        return;
+    createDataProperty(context, console, funcName, func);
 }
 
 } // namespace
 
 void V8Console::debugCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     ConsoleHelper(info).reportCall(ConsoleAPIType::kDebug);
 }
 
 void V8Console::errorCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
@@ skipping 222 matching lines @@
     if (!obj->GetOwnPropertyNames(context).ToLocal(&names))
         return;
     v8::Local<v8::Array> values = v8::Array::New(isolate, names->Length());
     for (size_t i = 0; i < names->Length(); ++i) {
         v8::Local<v8::Value> key;
         if (!names->Get(context, i).ToLocal(&key))
             continue;
         v8::Local<v8::Value> value;
         if (!obj->Get(context, key).ToLocal(&value))
             continue;
-        if (!values->Set(context, i, value).FromMaybe(false))
-            continue;
+        createDataProperty(context, values, i, value);
     }
     info.GetReturnValue().Set(values);
 }
 
 static void setFunctionBreakpoint(ConsoleHelper& helper, v8::Local<v8::Function> function, V8DebuggerAgentImpl::BreakpointSource source, const String16& condition, bool enable)
 {
     V8DebuggerAgentImpl* debuggerAgent = helper.debuggerAgent();
     if (!debuggerAgent)
         return;
     String16 scriptId = String16::fromInteger(function->ScriptId());
@@ skipping 285 matching lines @@
             continue;
         if (name->IsString()) {
             v8::Local<v8::Value> descriptor;
             bool success = m_global->GetOwnPropertyDescriptor(m_context, v8::Local<v8::String>::Cast(name)).ToLocal(&descriptor);
             DCHECK(success);
         }
     }
 }
 
 } // namespace v8_inspector