third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp - Issue 2269843002: [DevTools] Improve ConsoleAPI functions string description

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/InspectedContext.cpp

Issue 2269843002: [DevTools] Improve ConsoleAPI functions string description (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reverted set console in InspectedContext Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "platform/v8_inspector/InspectedContext.h"	5 #include "platform/v8_inspector/InspectedContext.h"

6	6

7 #include "platform/v8_inspector/InjectedScript.h"	7 #include "platform/v8_inspector/InjectedScript.h"

8 #include "platform/v8_inspector/V8Console.h"	8 #include "platform/v8_inspector/V8Console.h"

9 #include "platform/v8_inspector/V8InspectorImpl.h"	9 #include "platform/v8_inspector/V8InspectorImpl.h"

10 #include "platform/v8_inspector/V8StringUtil.h"	10 #include "platform/v8_inspector/V8StringUtil.h"

	11 #include "platform/v8_inspector/V8ValueCopier.h"

11 #include "platform/v8_inspector/public/V8ContextInfo.h"	12 #include "platform/v8_inspector/public/V8ContextInfo.h"

12 #include "platform/v8_inspector/public/V8InspectorClient.h"	13 #include "platform/v8_inspector/public/V8InspectorClient.h"

13	14

14 namespace v8_inspector {	15 namespace v8_inspector {

15	16

16 void InspectedContext::weakCallback(const v8::WeakCallbackInfo<InspectedContext> & data)	17 void InspectedContext::weakCallback(const v8::WeakCallbackInfo<InspectedContext> & data)

17 {	18 {

18 InspectedContext* context = data.GetParameter();	19 InspectedContext* context = data.GetParameter();

19 if (!context->m_context.IsEmpty()) {	20 if (!context->m_context.IsEmpty()) {

20 context->m_context.Reset();	21 context->m_context.Reset();

(...skipping 52 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 DCHECK(!m_injectedScript);	74 DCHECK(!m_injectedScript);

74 m_injectedScript = InjectedScript::create(this);	75 m_injectedScript = InjectedScript::create(this);

75 }	76 }

76	77

77 void InspectedContext::discardInjectedScript()	78 void InspectedContext::discardInjectedScript()

78 {	79 {

79 m_injectedScript.reset();	80 m_injectedScript.reset();

80 }	81 }

81	82

82 } // namespace v8_inspector	83 } // namespace v8_inspector

OLD	NEW