third_party/WebKit/Source/core/inspector/ThreadDebugger.h - Issue 2269843002: [DevTools] Improve ConsoleAPI functions string description

Side by Side Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

Issue 2269843002: [DevTools] Improve ConsoleAPI functions string description (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reverted set console in InspectedContext Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp ('k') | third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ThreadDebugger_h	5 #ifndef ThreadDebugger_h

6 #define ThreadDebugger_h	6 #define ThreadDebugger_h

7	7

8 #include "core/CoreExport.h"	8 #include "core/CoreExport.h"

9 #include "core/inspector/ConsoleTypes.h"	9 #include "core/inspector/ConsoleTypes.h"

10 #include "platform/Timer.h"	10 #include "platform/Timer.h"

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 void asyncTaskStarted(void* task);	44 void asyncTaskStarted(void* task);

45 void asyncTaskFinished(void* task);	45 void asyncTaskFinished(void* task);

46 unsigned promiseRejected(v8::Local<v8::Context>, const String& errorMessage, v8::Local<v8::Value> exception, std::unique_ptr<SourceLocation>);	46 unsigned promiseRejected(v8::Local<v8::Context>, const String& errorMessage, v8::Local<v8::Value> exception, std::unique_ptr<SourceLocation>);

47 void promiseRejectionRevoked(v8::Local<v8::Context>, unsigned promiseRejecti onId);	47 void promiseRejectionRevoked(v8::Local<v8::Context>, unsigned promiseRejecti onId);

48	48

49 protected:	49 protected:

50 virtual int contextGroupId(ExecutionContext*) = 0;	50 virtual int contextGroupId(ExecutionContext*) = 0;

51 virtual void reportConsoleMessage(ExecutionContext, MessageSource, MessageL evel, const String& message, SourceLocation) = 0;	51 virtual void reportConsoleMessage(ExecutionContext, MessageSource, MessageL evel, const String& message, SourceLocation) = 0;

52 void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::O bject>) override;	52 void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::O bject>) override;

53 void createFunctionProperty(v8::Local<v8::Context>, v8::Local<v8::Object>, c onst char* name, v8::FunctionCallback, const char* description);	53 void createFunctionProperty(v8::Local<v8::Context>, v8::Local<v8::Object>, c onst char* name, v8::FunctionCallback, const char* description);

	54 static v8::Maybe<bool> createDataPropertyInArray(v8::Local<v8::Context>, v8: :Local<v8::Array>, int index, v8::Local<v8::Value>);

54 static MessageLevel consoleAPITypeToMessageLevel(v8_inspector::V8ConsoleAPIT ype);	55 static MessageLevel consoleAPITypeToMessageLevel(v8_inspector::V8ConsoleAPIT ype);

55	56

56 v8::Isolate* m_isolate;	57 v8::Isolate* m_isolate;

57	58

58 private:	59 private:

59 // V8InspectorClient implementation.	60 // V8InspectorClient implementation.

60 void beginUserGesture() override;	61 void beginUserGesture() override;

61 void endUserGesture() override;	62 void endUserGesture() override;

62 String16 valueSubtype(v8::Local<v8::Value>) override;	63 String16 valueSubtype(v8::Local<v8::Value>) override;

63 bool formatAccessorsAsProperties(v8::Local<v8::Value>) override;	64 bool formatAccessorsAsProperties(v8::Local<v8::Value>) override;

(...skipping 16 matching lines...) Expand all Loading...
80 std::unique_ptr<v8_inspector::V8Inspector> m_v8Inspector;	81 std::unique_ptr<v8_inspector::V8Inspector> m_v8Inspector;

81 Vector<std::unique_ptr<Timer<ThreadDebugger>>> m_timers;	82 Vector<std::unique_ptr<Timer<ThreadDebugger>>> m_timers;

82 Vector<v8_inspector::V8InspectorClient::TimerCallback> m_timerCallbacks;	83 Vector<v8_inspector::V8InspectorClient::TimerCallback> m_timerCallbacks;

83 Vector<void*> m_timerData;	84 Vector<void*> m_timerData;

84 std::unique_ptr<UserGestureIndicator> m_userGestureIndicator;	85 std::unique_ptr<UserGestureIndicator> m_userGestureIndicator;

85 };	86 };

86	87

87 } // namespace blink	88 } // namespace blink

88	89

89 #endif // ThreadDebugger_h	90 #endif // ThreadDebugger_h

OLD	NEW