third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp - Issue 2269843002: [DevTools] Improve ConsoleAPI functions string description

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

Issue 2269843002: [DevTools] Improve ConsoleAPI functions string description (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reverted set console in InspectedContext Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8ValueCopier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

index 782e5bbab014739c75726871ec7dc193b38f4843..c3085751f74df174c46e15009c96675d950d037b 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

@@ -10,6 +10,7 @@

#include "platform/v8_inspector/V8InspectorImpl.h"

#include "platform/v8_inspector/V8InternalValueType.h"

#include "platform/v8_inspector/V8StringUtil.h"

+#include "platform/v8_inspector/V8ValueCopier.h"

#include "platform/v8_inspector/public/V8InspectorClient.h"

namespace v8_inspector {

@@ -23,8 +24,7 @@ void setFunctionProperty(v8::Local<v8::Context> context, v8::Local<v8::Object> o

if (!V8_FUNCTION_NEW_REMOVE_PROTOTYPE(context, callback, external, 0).ToLocal(&func))

return;

func->SetName(funcName);

- if (!obj->Set(context, funcName, func).FromMaybe(false))

- return;

+ createDataProperty(context, obj, funcName, func);

}

V8InspectorImpl* unwrapInspector(const v8::FunctionCallbackInfo<v8::Value>& info)