Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2268923003: Clean up textTrackDisplayElement utility function (Closed)

Created:
4 years, 4 months ago by Srirama
Modified:
4 years, 4 months ago
Reviewers:
fs, foolip
CC:
fs, blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up textTrackDisplayElement utility function Cleaned up textTrackDisplayElement and added required utility functions. Old usage => New usage textTrackDisplayElement(video) => textTrackContainerElement(video) textTrackDisplayElement(video, 'cue') => textTrackCueElementByIndex(video, 0).firstChild textTrackDisplayElement(video, 'display') => textTrackDisplayElement(video) textTrackDisplayElement(video, 'display', 0) => textTrackDisplayElement(video) textTrackDisplayElement(video, 'display', i) => textTrackCueElementByIndex(video, i) Committed: https://crrev.com/1e562714af113946049aad6faed41d8983eb8e56 Cr-Commit-Position: refs/heads/master@{#413726}

Patch Set 1 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -76 lines) Patch
M third_party/WebKit/LayoutTests/media/media-controls.js View 2 chunks +3 lines, -33 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/css-cue-for-video-in-shadow.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/css-cue-for-video-in-shadow-2.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/cue-style-invalidation.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-add-track.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/text-track-selection-menu-multiple-tracks.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-css-all-cues.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-css-cue-lifetime.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-css-matching.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-css-matching-default.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-css-matching-lang.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-css-matching-timestamps.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-css-property-whitelist.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-author-settings.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-internal-settings.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-container-rendering-position.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-mutable-text.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-rendering.html View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-rendering-mode-changed.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-rendering-on-resize.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-rendering-overscan.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-rendering-rtl.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-rendering-snap-to-lines-not-set.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-rendering-tree-is-removed-properly.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-rendering-wider-than-controls.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-cue-rendering-with-padding.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/track/track-word-breaking.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/video-controls-captions.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-controls-captions-on-off.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/video-controls-track-selection-menu.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Srirama
PTAL
4 years, 4 months ago (2016-08-23 12:33:00 UTC) #5
fs
lgtm
4 years, 4 months ago (2016-08-23 12:40:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268923003/20001
4 years, 4 months ago (2016-08-23 12:43:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-23 14:00:55 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 14:02:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e562714af113946049aad6faed41d8983eb8e56
Cr-Commit-Position: refs/heads/master@{#413726}

Powered by Google App Engine
This is Rietveld 408576698