third_party/WebKit/LayoutTests/media/track/track-cue-rendering-on-resize.html - Issue 2268923003: Clean up textTrackDisplayElement utility function

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/track/track-cue-rendering-on-resize.html

Issue 2268923003: Clean up textTrackDisplayElement utility function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-cue-rendering-mode-changed.html ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-rendering-overscan.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Test that line height of cue element isn't overridden by author CSS.</tit le>	2 <title>Test that line height of cue element isn't overridden by author CSS.</tit le>

3 <script src="../media-file.js"></script>	3 <script src="../media-file.js"></script>

4 <script src="../media-controls.js"></script>	4 <script src="../media-controls.js"></script>

5 <script src="../../resources/testharness.js"></script>	5 <script src="../../resources/testharness.js"></script>

6 <script src="../../resources/testharnessreport.js"></script>	6 <script src="../../resources/testharnessreport.js"></script>

7 <style>	7 <style>

8 body { line-height: 108px; }	8 body { line-height: 108px; }

9 </style>	9 </style>

10 <video>	10 <video>

11 <track src="captions-webvtt/captions-snap-to-lines-set.vtt" kind="captions" default>	11 <track src="captions-webvtt/captions-snap-to-lines-set.vtt" kind="captions" default>

12 </video>	12 </video>

13 <script>	13 <script>

14 async_test(function(t) {	14 async_test(function(t) {

15 var video = document.querySelector('video');	15 var video = document.querySelector('video');

16 video.src = findMediaFile('video', '../content/test');	16 video.src = findMediaFile('video', '../content/test');

17	17

18 video.onseeked = t.step_func_done(function() {	18 video.onseeked = t.step_func_done(function() {

19 var multiLineCueDisplayElement = textTrackDisplayElement(video, 'display ', 0);	19 var multiLineCueDisplayElement = textTrackDisplayElement(video);

20 assert_equals(getComputedStyle(multiLineCueDisplayElement).lineHeight, ' normal');	20 assert_equals(getComputedStyle(multiLineCueDisplayElement).lineHeight, ' normal');

21 });	21 });

22	22

23 video.currentTime = 1.25;	23 video.currentTime = 1.25;

24 });	24 });

25 </script>	25 </script>

OLD	NEW