third_party/WebKit/LayoutTests/media/track/track-cue-rendering.html - Issue 2268923003: Clean up textTrackDisplayElement utility function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-cue-rendering.html

Issue 2268923003: Clean up textTrackDisplayElement utility function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-cue-nothing-to-render.html ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-rendering-mode-changed.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/track/track-cue-rendering.html

diff --git a/third_party/WebKit/LayoutTests/media/track/track-cue-rendering.html b/third_party/WebKit/LayoutTests/media/track/track-cue-rendering.html

index d88822053854eb482a44864b11e6c0f55ddca36f..13f7ce90b5a5f27b3f96f749451f4888d70b22e7 100644

--- a/third_party/WebKit/LayoutTests/media/track/track-cue-rendering.html

+++ b/third_party/WebKit/LayoutTests/media/track/track-cue-rendering.html

@@ -20,7 +20,7 @@ async_test(function(t) {

assert_equals(testTrack.track.activeCues.length, 1);

assert_equals(testTrack.track.activeCues[0].text, cueText[cueTextIndex]);

- var testCueDisplayBox = textTrackDisplayElement(video, "display");

+ var testCueDisplayBox = textTrackDisplayElement(video);

assert_equals(testCueDisplayBox.innerText, cueText[cueTextIndex]);

assert_equals(2 * testCueDisplayBox.offsetLeft, video.videoWidth - testCueDisplayBox.offsetWidth)

@@ -31,9 +31,9 @@ async_test(function(t) {

testFontSize(1280, 960);

testFontSize(2560, 1440);

- assert_equals(getComputedStyle(textTrackDisplayElement(video)).fontFamily, "sans-serif");

- assert_equals(getComputedStyle(textTrackDisplayElement(video)).color, "rgb(255, 255, 255)");

- assert_equals(getComputedStyle(textTrackDisplayElement(video, "display").firstChild).backgroundColor, "rgba(0, 0, 0, 0.8)");

+ assert_equals(getComputedStyle(textTrackContainerElement(video)).fontFamily, "sans-serif");

+ assert_equals(getComputedStyle(textTrackContainerElement(video)).color, "rgb(255, 255, 255)");

+ assert_equals(getComputedStyle(textTrackDisplayElement(video).firstChild).backgroundColor, "rgba(0, 0, 0, 0.8)");

t.done();

} else {

@@ -46,7 +46,7 @@ async_test(function(t) {

video.height = height;

// Force a relayout of the document

document.body.offsetTop;

- assert_equals(getComputedStyle(textTrackDisplayElement(video)).fontSize, parseInt(height * 0.05) + "px");

+ assert_equals(getComputedStyle(textTrackContainerElement(video)).fontSize, parseInt(height * 0.05) + "px");

}

video.currentTime = 0.5;