third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-internal-settings.html - Issue 2268923003: Clean up textTrackDisplayElement utility function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-internal-settings.html

Issue 2268923003: Clean up textTrackDisplayElement utility function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-author-settings.html ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-container-rendering-position.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-internal-settings.html

diff --git a/third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-internal-settings.html b/third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-internal-settings.html

index c06693adf195ea02c12556844544aadbb6c88d02..cde58678e5a44151b6de309119af15636902c9e6 100644

--- a/third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-internal-settings.html

+++ b/third_party/WebKit/LayoutTests/media/track/track-css-user-settings-override-internal-settings.html

@@ -13,7 +13,7 @@ async_test(function(t) {

video.src = findMediaFile("video", "../content/test");

video.oncanplaythrough = t.step_func_done(function() {

- var cue = textTrackDisplayElement(video, "cue");

+ var cue = textTrackCueElementByIndex(video, 0).firstChild;

var cueStyle = getComputedStyle(cue);

// These are the expected default cue settings per spec

// http://dev.w3.org/html5/webvtt/#applying-css-properties-to-webvtt-node-objects

@@ -27,7 +27,7 @@ async_test(function(t) {

video.currentTime = 0.3;

- cue = textTrackDisplayElement(video, "cue");

+ cue = textTrackCueElementByIndex(video, 0).firstChild;

cueStyle = getComputedStyle(cue);

assert_equals(cueStyle.color, "rgb(128, 0, 128)");

assert_equals(cueStyle.fontSize, "14px");