third_party/WebKit/LayoutTests/media/track/track-cue-rendering-mode-changed.html - Issue 2268923003: Clean up textTrackDisplayElement utility function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-cue-rendering-mode-changed.html

Issue 2268923003: Clean up textTrackDisplayElement utility function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-cue-rendering.html ('k') | third_party/WebKit/LayoutTests/media/track/track-cue-rendering-on-resize.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/track/track-cue-rendering-mode-changed.html

diff --git a/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-mode-changed.html b/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-mode-changed.html

index dec19058ed2fa39b0dba365b72e3860792aab794..e5fb2fdd1a3565049bbe647b3025a41e4edf5e99 100644

--- a/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-mode-changed.html

+++ b/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-mode-changed.html

@@ -46,7 +46,7 @@ async_test(function(t) {

function testCueVisibility() {

// Only one cue should be visible.

- testCueDisplayBox = textTrackDisplayElement(video, 'display', 0);

+ testCueDisplayBox = textTrackCueElementByIndex(video, 0);

assert_equals(testCueDisplayBox.innerText, 'Arabic');

assert_equals(testCueDisplayBox.nextSibling, null);

@@ -54,10 +54,10 @@ async_test(function(t) {

testTrackEnglish.mode = 'showing';

// Both cues shold be visible.

- testCueDisplayBox = textTrackDisplayElement(video, 'display', 0);

+ testCueDisplayBox = textTrackCueElementByIndex(video, 0);

assert_equals(testCueDisplayBox.innerText, 'Arabic');

- testCueDisplayBox = textTrackDisplayElement(video, 'display', 1);

+ testCueDisplayBox = textTrackCueElementByIndex(video, 1);

assert_equals(testCueDisplayBox.innerText, 'English');

}

});