Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2266153002: Modify UsbDeviceFilter::MatchesAny to return true for empty filters (Closed)

Created:
4 years, 4 months ago by juncai
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify UsbDeviceFilter::MatchesAny to return true for empty filters Since some code that calls UsbDeviceFilter::MatchesAny already checks if filters is empty, it would be nice to move this check inside the function. Also it will make writing test code a little easier. BUG=639928 Committed: https://crrev.com/d893fe00f1bf2562d754475b85adb23b09f2559f Cr-Commit-Position: refs/heads/master@{#413785}

Patch Set 1 : modified UsbDeviceFilter::MatchesAny to return true for empty filters #

Patch Set 2 : fixed code for unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M device/usb/mojo/device_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb_device_filter.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M device/usb/usb_device_filter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/device_permissions_prompt.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/printer_provider/usb_printer_manifest_data.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (11 generated)
juncai
Please take a look.
4 years, 4 months ago (2016-08-22 20:34:26 UTC) #4
Reilly Grant (use Gerrit)
lgtm
4 years, 4 months ago (2016-08-22 20:49:01 UTC) #5
juncai
To fix unit test failure of PrinterDetectorAppSearchEnabledTest.PrinterProvider_DifferentUsbProductId, need to modify UsbPrinterManifestData::SupportsDevice() to deal with empty ...
4 years, 4 months ago (2016-08-23 00:41:05 UTC) #10
Reilly Grant (use Gerrit)
lgtm
4 years, 4 months ago (2016-08-23 17:25:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266153002/20001
4 years, 4 months ago (2016-08-23 17:32:14 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-23 18:08:54 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 18:12:19 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d893fe00f1bf2562d754475b85adb23b09f2559f
Cr-Commit-Position: refs/heads/master@{#413785}

Powered by Google App Engine
This is Rietveld 408576698