extensions/browser/api/device_permissions_prompt.cc - Issue 2266153002: Modify UsbDeviceFilter::MatchesAny to return true for empty filters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/device_permissions_prompt.cc

Issue 2266153002: Modify UsbDeviceFilter::MatchesAny to return true for empty filters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed code for unit test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/device_permissions_prompt.cc

diff --git a/extensions/browser/api/device_permissions_prompt.cc b/extensions/browser/api/device_permissions_prompt.cc

index 4a6c0e6186410976c73558a24f2af94662472d6b..96a940f0cc812d7f05afd2f495570f1c86a408b1 100644

--- a/extensions/browser/api/device_permissions_prompt.cc

+++ b/extensions/browser/api/device_permissions_prompt.cc

@@ -126,9 +126,8 @@ class UsbDevicePermissionsPrompt : public DevicePermissionsPrompt::Prompt,

// device::UsbService::Observer implementation:

void OnDeviceAdded(scoped_refptr<UsbDevice> device) override {

- if (!(filters_.empty() || UsbDeviceFilter::MatchesAny(device, filters_))) {

+ if (!UsbDeviceFilter::MatchesAny(device, filters_))

return;

- }

std::unique_ptr<DeviceInfo> device_info(new UsbDeviceInfo(device));

device->CheckUsbAccess(

« no previous file with comments | « device/usb/usb_device_filter_unittest.cc ('k') | extensions/browser/api/usb/usb_api.cc » ('j') | no next file with comments »