device/usb/mojo/device_manager_impl.cc - Issue 2266153002: Modify UsbDeviceFilter::MatchesAny to return true for empty filters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/mojo/device_manager_impl.cc

Issue 2266153002: Modify UsbDeviceFilter::MatchesAny to return true for empty filters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed code for unit test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/usb/mojo/device_manager_impl.cc

diff --git a/device/usb/mojo/device_manager_impl.cc b/device/usb/mojo/device_manager_impl.cc

index 0b71c390922cb9791e367c8d1cdcf05488313c60..1f6625db8c0fb980feefaf51880c3fc3038689a2 100644

--- a/device/usb/mojo/device_manager_impl.cc

+++ b/device/usb/mojo/device_manager_impl.cc

@@ -91,7 +91,7 @@ void DeviceManagerImpl::OnGetDevices(

std::vector<DeviceInfoPtr> device_infos;

for (const auto& device : devices) {

- if (filters.empty() || UsbDeviceFilter::MatchesAny(device, filters)) {

+ if (UsbDeviceFilter::MatchesAny(device, filters)) {

if (permission_provider_ &&

permission_provider_->HasDevicePermission(device)) {

device_infos.push_back(DeviceInfo::From(*device));

« no previous file with comments | « no previous file | device/usb/usb_device_filter.cc » ('j') | no next file with comments »