Add unit test for UsbChooserController

Add unit test for UsbChooserController

This CL adds some unit tests for code that deals with displaying USB
devices that have the same name on the chooser.

BUG=637402
Committed: https://crrev.com/2ef45ff9caf531d43a366186a7c80d7307d91252
Cr-Commit-Position: refs/heads/master@{#413929}

[juncai, 2016-08-23 17:55:33]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 17:55:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-08-23 18:03:33]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 18:04:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-08-23 18:11:06]

juncai@chromium.org changed reviewers:
+ reillyg@chromium.org, sky@chromium.org

[juncai, 2016-08-23 18:11:07]

sky@chromium.org: Please review changes in
//chrome/chrome_tests_unit.gypi

reillyg@chromium.org: Please review changes in
//chrome/browser/usb/usb_chooser_controller_unittest.cc

[Reilly Grant (use Gerrit), 2016-08-23 18:30:19]

https://codereview.chromium.org/2269993004/diff/20001/chrome/browser/usb/usb_...
File chrome/browser/usb/usb_chooser_controller_unittest.cc (right):

https://codereview.chromium.org/2269993004/diff/20001/chrome/browser/usb/usb_...
chrome/browser/usb/usb_chooser_controller_unittest.cc:25:
switches::kDisableWebUsbSecurity);
I'm planning to remove this flag so I'd rather this test be written to use a
specific test domain.

[commit-bot: I haz the power, 2016-08-23 18:43:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 18:43:26]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sky, 2016-08-23 20:43:20]

chrome/*.gypi has owners of *, so you can pick anyone you want. That said, LGTM

[juncai, 2016-08-23 23:18:05]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 23:19:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-08-23 23:21:58]

On 2016/08/23 20:43:20, sky wrote:
> chrome/*.gypi has owners of *, so you can pick anyone you want. That said,
LGTM

I see. Thanks.

[juncai, 2016-08-23 23:22:06]

https://codereview.chromium.org/2269993004/diff/20001/chrome/browser/usb/usb_...
File chrome/browser/usb/usb_chooser_controller_unittest.cc (right):

https://codereview.chromium.org/2269993004/diff/20001/chrome/browser/usb/usb_...
chrome/browser/usb/usb_chooser_controller_unittest.cc:25:
switches::kDisableWebUsbSecurity);
On 2016/08/23 18:30:18, Reilly Grant wrote:
> I'm planning to remove this flag so I'd rather this test be written to use a
> specific test domain.

Done.

[juncai, 2016-08-23 23:44:11]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 23:45:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2016-08-24 00:19:06]

lgtm with a nit

https://codereview.chromium.org/2269993004/diff/60001/chrome/browser/usb/usb_...
File chrome/browser/usb/usb_chooser_controller_unittest.cc (right):

https://codereview.chromium.org/2269993004/diff/60001/chrome/browser/usb/usb_...
chrome/browser/usb/usb_chooser_controller_unittest.cc:70: CreateMockUsbDevice(0,
1, "Google", "a", "001");
These first 3 parameters to CreateMockUsbDevice() seem to always be the same.

[juncai, 2016-08-24 00:38:12]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 00:38:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 01:23:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 01:24:00]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-08-24 01:26:21]

https://codereview.chromium.org/2269993004/diff/60001/chrome/browser/usb/usb_...
File chrome/browser/usb/usb_chooser_controller_unittest.cc (right):

https://codereview.chromium.org/2269993004/diff/60001/chrome/browser/usb/usb_...
chrome/browser/usb/usb_chooser_controller_unittest.cc:70: CreateMockUsbDevice(0,
1, "Google", "a", "001");
On 2016/08/24 00:19:06, Reilly Grant wrote:
> These first 3 parameters to CreateMockUsbDevice() seem to always be the same.

Done.

[juncai, 2016-08-24 01:26:41]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-08-24 01:26:41]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2269993004/#ps80001
(title: "address more comment")

[commit-bot: I haz the power, 2016-08-24 01:27:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 01:34:16]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-24 01:37:36]

Description was changed from

==========
Add unit test for UsbChooserController

This CL adds some unit tests for code that deals with displaying USB
devices that have the same name on the chooser.

BUG=637402
==========

to

==========
Add unit test for UsbChooserController

This CL adds some unit tests for code that deals with displaying USB
devices that have the same name on the chooser.

BUG=637402

Committed: https://crrev.com/2ef45ff9caf531d43a366186a7c80d7307d91252
Cr-Commit-Position: refs/heads/master@{#413929}
==========

[commit-bot: I haz the power, 2016-08-24 01:37:37]

Patchset 5 (id:??) landed as
https://crrev.com/2ef45ff9caf531d43a366186a7c80d7307d91252
Cr-Commit-Position: refs/heads/master@{#413929}